From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755341AbcFQJUN (ORCPT ); Fri, 17 Jun 2016 05:20:13 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:41847 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754850AbcFQJUJ (ORCPT ); Fri, 17 Jun 2016 05:20:09 -0400 Subject: Re: [PATCH V2 31/63] clocksource/drivers/tango_xtal: Convert init function to return error To: Daniel Lezcano , Thomas Gleixner References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-32-git-send-email-daniel.lezcano@linaro.org> Cc: LKML , Sebastian Frias From: Mason Message-ID: <5763C0BE.8090900@free.fr> Date: Fri, 17 Jun 2016 11:19:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-32-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2016 23:26, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/sun4i_timer.c | 45 ++++++++++++++++++++++++++++----------- > 1 file changed, 32 insertions(+), 13 deletions(-) NACK ;-) The subject specifies tango_xtal, but the patch changes sun4i_timer. (Looks like all patches in the series are off by one.) And I see you've already acknowledged the issue an hour ago. The actual patch for tango_xtal is [PATCH V2 32/63] clocksource/drivers/tegra20_timer BTW, I wasn't CCed on the tango_xtal patch. I suppose I forgot to add the appropriate line in MAINTAINERS? Regards.