Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF

From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: <linux-kernel@vger.kernel.org>, <linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF
Date: Fri, 17 Jun 2016 18:05:09 +0530	[thread overview]
Message-ID: <5763EE7D.4000600@ti.com> (raw)
In-Reply-To: <7658149.o0yR5eAPe1@diego>

Hi Heiko,

On Tuesday 03 May 2016 04:32 PM, Heiko Stübner wrote:
> Hi Kishon,
> 
> Am Dienstag, 3. Mai 2016, 16:28:35 schrieb Kishon Vijay Abraham I:
>> On Sunday 01 May 2016 01:37 AM, Heiko Stübner wrote:
>>> Am Dienstag, 19. April 2016, 08:13:47 schrieb Heiko Stübner:
>>>> Am Donnerstag, 31. März 2016, 15:43:30 schrieb Heiko Stuebner:
>>>>> The usb-phy is fully enclosed in the general register files (GRF).
>>>>> Therefore as seen from the device-tree it shouldn't be a separate
>>>>> platform-
>>>>> device but instead a sub-device of the GRF - using the simply-mfd
>>>>> mechanism.
>>>>>
>>>>> As the usb-phy is part of the kernel for some releases now, we keep
>>>>> the old (and now deprecated) binding for compatibility purposes.
>>>>>
>>>>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>>>>
>>>> could you look into picking this patch up for 4.7?
>>>>
>>>> Same principle as for the other phy drivers, but it's already in the
>>>> kernel
>>>> for a while, so it gets a fallback for the old binding and can go through
>>>> the normal way.
>>>>
>>>> The other two (devicetree-)patches I would then simply queue for 4.8
>>>> myself
>>>> after you're fine with the driver-side.
>>>
>>> just saw that you already have a tag for 4.7-related phy changes since
>>> this
>>> afternoon, but no phy pull to Greg on lkml yet.
>>>
>>> So maybe there is still a way for this phy conversion (to be under the
>>> Rockchip GRF node) to make it in for 4.7 :-) ?
>>
>> Looks like I've missed this before sending the pull request. Sorry about
>> that. Is it okay if the PHY changes also go in 4.8?
> 
> yep, 4.8 is no problem as well. We have the current binding in the kernel for 
> so long, that waiting one more kernel release won't be a problem.

Can you resend the patch after fixing these checkpatch warnings?
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#52:
device but instead a sub-device of the GRF - using the simply-mfd mechanism.

WARNING: line over 80 characters
#123: FILE: drivers/phy/phy-rockchip-usb.c:402:
+		phy_base->reg_base = syscon_node_to_regmap(dev->parent->of_node);

total: 0 errors, 2 warnings, 68 lines checked

After that I'll take them in my -next.

Thanks
Kishon