From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933788AbcFQMn0 (ORCPT ); Fri, 17 Jun 2016 08:43:26 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36227 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933557AbcFQMnW (ORCPT ); Fri, 17 Jun 2016 08:43:22 -0400 Subject: Re: [PATCH V3] clocksource/drivers/tango_xtal: Convert init function to return error To: Marc Gonzalez , Thomas Gleixner References: <5763C0BE.8090900@free.fr> <1466159197-23203-1-git-send-email-daniel.lezcano@linaro.org> <5763EE87.9010207@sigmadesigns.com> Cc: LKML , Mason , Sebastian Frias From: Daniel Lezcano Message-ID: <5763F067.5020809@linaro.org> Date: Fri, 17 Jun 2016 14:43:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5763EE87.9010207@sigmadesigns.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 02:35 PM, Marc Gonzalez wrote: > On 17/06/2016 12:26, Daniel Lezcano wrote: > >> The init functions do not return any error. They behave as the following: >> >> - panic, thus leading to a kernel crash while another timer may work and >> make the system boot up correctly >> >> or >> >> - print an error and let the caller unaware if the state of the system > ^^^ ^^ > "leave the caller unaware of [...]" (?) > >> Change that by converting the init functions to return an error conforming >> to the CLOCKSOURCE_OF_RET prototype. >> >> Proper error handling (rollback, errno value) will be changed later case >> by case, thus this change just return back an error or success in the init > ^^^^^^^^^^^ > "just returns an error code from the init function" (?) Ok, I will do the change when adding the acked-by tag. [ ... ] > The code looks good to me. > Acked-by: Marc Gonzalez > > Could you merge, on top of these, the patch we discussed a few weeks ago > for changing ret to err? (I will attach the patch to this message.) I don't really mind to convert 'ret' to 'err' if it is your preference but can it wait after the changes I initiated ? Much more patches will come to consolidate the init functions. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog