From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928AbcFTHza (ORCPT ); Mon, 20 Jun 2016 03:55:30 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:55772 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbcFTHzJ (ORCPT ); Mon, 20 Jun 2016 03:55:09 -0400 X-AuditID: cbfec7f4-f796c6d000001486-fb-57679e394ad4 Message-id: <57679E38.3080901@samsung.com> Date: Mon, 20 Jun 2016 09:41:44 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: "Andrew F. Davis" Cc: Russell King , Miguel Ojeda Sandonis , Linus Walleij , Sebastian Reichel , Wolfram Sang , Richard Purdie , Rusty Russell , Benjamin Herrenschmidt , Mauro Carvalho Chehab , Ulf Hansson , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , Ingo Molnar , linux-pwm@vger.kernel.org, lguest@lists.ozlabs.org, linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS is set References: <20160613200211.14790-1-afd@ti.com> <20160613200211.14790-13-afd@ti.com> <5760FA52.7010806@samsung.com> <57647DBD.2010406@ti.com> In-reply-to: <57647DBD.2010406@ti.com> Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Ra0iTYRTHe/Ze9jqavC2tJ6Pb7AJCpij6WCJ96MP7IcogWEmgU1+n5XRu alpEKxZ4I7MsdV5WrdKmqXjJUrsNcW5Dswaa4CbTvNHExEGaNnOuwG+/c87vnP+HQ2GCMdyP SknLZOVp4lQhycPNLoPlaESNRBRUNn0CzZtKuEjbYcPRz9t3MPRaW4qhSZcZQ6WrtRzUqlkF KO+PEyBLZxWJ2h2NABU1txOoZ60YIKtVB5CjbpSL9A/fAbTyy0Wg+qkcNFLm4KJ6lwmgrs5J Ao08GsSRuZBA5q5MZHglQi/71NjJXYxl6AvGvFVbuUyRQ0UwLbp8khkd6iaZGuM55nP5E8BU V/wmmbbidaNbs0Qwdc19GGM0fccZw7cODrPYsjfaO4YXmcimpmSz8mNRcbzk0qe1uMxJ5yyO LHCUoIBfALwoSIfCD/Z8rod3wEFbE1kAeJSAfg5g3seZf8UUgM7ZOY7b4tMBcPjWxAbj9CGo bWjD3EzSwXB55sdG35e+AFfN7wmPvw0uPbDhbvahhVBpLCTcRzG6mAtVswvrBUVtp2OhuZbr CSsB0J5v31j2og/DgWcVG8sYHQbHVY2Yh/fB1oY57B6g1Zsy1Js09SbtMcB0wJfNSpAp4iXS 4ECFWKrISpMEJqRLW4Dn7c43QNt7XA9oCgi38lF/kkhAiLMVuVI9gBQm9OH3VElEAn6iOPca K0+PlWelsgo92E3hwp386s758wJaIs5kr7CsjJX/n3IoLz8laLKoVvw6mq8meX8at4fJvMZu Hjib4zfx1RVOjBlNITPX/Q844+5vofwz+I1s/+X4g8sy3LA/ovxIq3Ut4FKQMoEjquy1YYMZ kfEXw3ty8cobsjMic/QLQn13wES3amKlRD/vVGnU6dCwmFwph++vG9Z0kfnWOjRdPlAQskeI K5LFwQGYXCH+CygemwHyAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2016 12:46 AM, Andrew F. Davis wrote: > On 06/15/2016 01:48 AM, Jacek Anaszewski wrote: >> Hi Andrew, >> >> Thanks for the patch. >> >> Please address the issue [1] raised by test bot and resubmit. >> >> Thanks, >> Jacek Anaszewski >> >> [1] https://lkml.org/lkml/2016/6/13/1091 >> > > It looks like some systems use 'gpio_led_register_device' to make an > in-memory copy of their LED device table so the original can be removed > as .init.rodata. This doesn't necessarily depend on the LED subsystem > but it kind of seems useless when the rest of the subsystem is disabled. > > One solution could be to use a dummy 'gpio_led_register_device' when the > subsystem is not enabled. It sounds good. Please add a no-op version of gpio_led_register_device() to include/leds.h, in a separate patch. Thanks, Jacek Anaszewski > Another is just to remove the five or so uses > of 'gpio_led_register_device' and have those systems register LED device > tables like other systems do. > > If nether of these are acceptable then this patch can be dropped from > this series for now. > > Thanks, > Andrew > >> On 06/13/2016 10:02 PM, Andrew F. Davis wrote: >>> When CONFIG_NEW_LEDS is not set make will still descend into the leds >>> directory but nothing will be built. This produces unneeded build >>> artifacts and messages in addition to slowing the build. Fix this here. >>> >>> Signed-off-by: Andrew F. Davis >>> --- >>> drivers/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/Makefile b/drivers/Makefile >>> index 567e32c..fa514d5 100644 >>> --- a/drivers/Makefile >>> +++ b/drivers/Makefile >>> @@ -127,7 +127,7 @@ obj-$(CONFIG_CPU_FREQ) += cpufreq/ >>> obj-$(CONFIG_CPU_IDLE) += cpuidle/ >>> obj-$(CONFIG_MMC) += mmc/ >>> obj-$(CONFIG_MEMSTICK) += memstick/ >>> -obj-y += leds/ >>> +obj-$(CONFIG_NEW_LEDS) += leds/ >>> obj-$(CONFIG_INFINIBAND) += infiniband/ >>> obj-$(CONFIG_SGI_SN) += sn/ >>> obj-y += firmware/ >>> >> >> > >