From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753460AbcFTIqT (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jun 2016 04:46:19 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:46168 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752237AbcFTIqM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jun 2016 04:46:12 -0400
Subject: Re: [PATCH 7/9] mfd: tps65218: add version check to the PMIC probe
To: Keerthy <j-keerthy@ti.com>, <tony@atomide.com>, <broonie@kernel.org>,
        <devicetree@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>
References: <1466412218-5906-1-git-send-email-j-keerthy@ti.com>
 <1466412218-5906-8-git-send-email-j-keerthy@ti.com>
CC: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <t-kristo@ti.com>, <russ.dill@ti.com>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <linux@armlinux.org.uk>,
        Dave Gerlach <d-gerlach@ti.com>
From: Keerthy <a0393675@ti.com>
Message-ID: <5767AD43.9080101@ti.com>
Date: Mon, 20 Jun 2016 14:15:55 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1466412218-5906-8-git-send-email-j-keerthy@ti.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Monday 20 June 2016 02:13 PM, Keerthy wrote:
> From: Tero Kristo <t-kristo@ti.com>
>
> Version information will be needed to handle some error cases under the
> regulator driver, so store the information once during MFD probe.

+ Lee Jones.

>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>   drivers/mfd/tps65218.c       | 9 +++++++++
>   include/linux/mfd/tps65218.h | 1 +
>   2 files changed, 10 insertions(+)
>
> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
> index 80b9dc3..ba610ad 100644
> --- a/drivers/mfd/tps65218.c
> +++ b/drivers/mfd/tps65218.c
> @@ -219,6 +219,7 @@ static int tps65218_probe(struct i2c_client *client,
>   	struct tps65218 *tps;
>   	const struct of_device_id *match;
>   	int ret;
> +	unsigned int chipid;
>
>   	match = of_match_device(of_tps65218_match_table, &client->dev);
>   	if (!match) {
> @@ -250,6 +251,14 @@ static int tps65218_probe(struct i2c_client *client,
>   	if (ret < 0)
>   		return ret;
>
> +	ret = tps65218_reg_read(tps, TPS65218_REG_CHIPID, &chipid);
> +	if (ret) {
> +		dev_err(tps->dev, "Failed to read chipid: %d\n", ret);
> +		return ret;
> +	}
> +
> +	tps->rev = chipid & TPS65218_CHIPID_REV_MASK;
> +
>   	ret = of_platform_populate(client->dev.of_node, NULL, NULL,
>   				   &client->dev);
>   	if (ret < 0)
> diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h
> index 7fdf532..85e464e 100644
> --- a/include/linux/mfd/tps65218.h
> +++ b/include/linux/mfd/tps65218.h
> @@ -267,6 +267,7 @@ struct tps_info {
>   struct tps65218 {
>   	struct device *dev;
>   	unsigned int id;
> +	u8 rev;
>
>   	struct mutex tps_lock;		/* lock guarding the data structure */
>   	/* IRQ Data */
>