From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246AbcFTJMw (ORCPT ); Mon, 20 Jun 2016 05:12:52 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35500 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbcFTJLc (ORCPT ); Mon, 20 Jun 2016 05:11:32 -0400 Subject: Re: [PATCH] gpio: sx150x: Update OF configuration To: Linus Walleij References: <1466157063-10955-1-git-send-email-narmstrong@baylibre.com> Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Neil Armstrong Organization: Baylibre Message-ID: <5767B16D.8080600@baylibre.com> Date: Mon, 20 Jun 2016 11:03:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2016 11:02 AM, Linus Walleij wrote: > On Fri, Jun 17, 2016 at 11:51 AM, Neil Armstrong > wrote: > >> In case of OF probing, the driver fails to initialize : >> - gpio_chip.base must be -1 >> - irq_summary must be either -1 or valid >> - There is no way to use the other configurations >> >> Add OF parsing function to complete the HW configuration, make >> OF configuration dynamic instead of static with #defines and >> update the DT bindings. >> >> Signed-off-by: Neil Armstrong > > As you can see from the result of the build robot, the removal > of #ifdef CONFIG_OF_GPIO does not play well with non-DT > configurarions. > > You need to figure something out here so that it builds for > both. OK, I'll find out. Thanks, Neil > Yours, > Linus Walleij >