From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932633AbcFTLdm (ORCPT ); Mon, 20 Jun 2016 07:33:42 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:53229 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932615AbcFTLd1 (ORCPT ); Mon, 20 Jun 2016 07:33:27 -0400 Subject: Re: [PATCH V2 18/63] clocksource/drivers/arm_global_timer: Convert init function to return error To: Daniel Lezcano , References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-19-git-send-email-daniel.lezcano@linaro.org> CC: , Srinivas Kandagatla , Patrice Chotard , "moderated list:ARM/STI ARCHITECTURE" , "open list:ARM/STI ARCHITECTURE" From: Maxime Coquelin Message-ID: <5767D465.8010506@st.com> Date: Mon, 20 Jun 2016 13:32:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-19-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.0.47] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-20_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2016 11:26 PM, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/arm_global_timer.c | 28 ++++++++++++++++++---------- > 1 file changed, 18 insertions(+), 10 deletions(-) > > Acked-by: Maxime Coquelin Thanks! Maxime