From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550AbcFTLxz (ORCPT ); Mon, 20 Jun 2016 07:53:55 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:38149 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881AbcFTLxd (ORCPT ); Mon, 20 Jun 2016 07:53:33 -0400 Subject: Re: [PATCH v7 1/4] usb: dwc3: core.h: add some register definitions To: Felipe Balbi References: <1465564650-27516-1-git-send-email-rogerq@ti.com> <1465564650-27516-2-git-send-email-rogerq@ti.com> <87fus8qkep.fsf@linux.intel.com> CC: , , , , , , , , , , From: Roger Quadros Message-ID: <5767D921.60509@ti.com> Date: Mon, 20 Jun 2016 14:53:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <87fus8qkep.fsf@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HdVjA76D2Q4n7O8cRfPqEFNOXhMSeh9Fc" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HdVjA76D2Q4n7O8cRfPqEFNOXhMSeh9Fc Content-Type: multipart/mixed; boundary="nOXMLfIKmMcKFqaM1pPTwKbpRwuQBEw8M" From: Roger Quadros To: Felipe Balbi Cc: tony@atomide.com, Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com, peter.chen@freescale.com, jun.li@freescale.com, grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com, nsekhar@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Message-ID: <5767D921.60509@ti.com> Subject: Re: [PATCH v7 1/4] usb: dwc3: core.h: add some register definitions References: <1465564650-27516-1-git-send-email-rogerq@ti.com> <1465564650-27516-2-git-send-email-rogerq@ti.com> <87fus8qkep.fsf@linux.intel.com> In-Reply-To: <87fus8qkep.fsf@linux.intel.com> --nOXMLfIKmMcKFqaM1pPTwKbpRwuQBEw8M Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 20/06/16 12:28, Felipe Balbi wrote: >=20 > Hi, >=20 > Roger Quadros writes: >> Add OTG and GHWPARAMS6 register definitions >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/dwc3/core.h | 84 ++++++++++++++++++++++++++++++++++++++++= ++++++++- >> 1 file changed, 83 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >> index 8fb6361..32bb7531 100644 >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -197,6 +197,15 @@ >> #define DWC3_GCTL_GBLHIBERNATIONEN (1 << 1) >> #define DWC3_GCTL_DSBLCLKGTNG (1 << 0) >> =20 >> +/* Global Status Register */ >> +#define DWC3_GSTS_OTG_IP BIT(10) >> +#define DWC3_GSTS_BC_IP BIT(9) >> +#define DWC3_GSTS_ADP_IP BIT(8) >> +#define DWC3_GSTS_HOST_IP BIT(7) >> +#define DWC3_GSTS_DEVICE_IP BIT(6) >> +#define DWC3_GSTS_CSR_TIMEOUT BIT(5) >> +#define DWC3_GSTS_BUS_ERR_ADDR_VLD BIT(4) >> + >> /* Global USB2 PHY Configuration Register */ >> #define DWC3_GUSB2PHYCFG_PHYSOFTRST (1 << 31) >> #define DWC3_GUSB2PHYCFG_SUSPHY (1 << 6) >> @@ -269,7 +278,12 @@ >> #define DWC3_MAX_HIBER_SCRATCHBUFS 15 >> =20 >> /* Global HWPARAMS6 Register */ >> -#define DWC3_GHWPARAMS6_EN_FPGA (1 << 7) >> +#define DWC3_GHWPARAMS6_BCSUPPORT BIT(14) >> +#define DWC3_GHWPARAMS6_OTG3SUPPORT BIT(13) >> +#define DWC3_GHWPARAMS6_ADPSUPPORT BIT(12) >> +#define DWC3_GHWPARAMS6_HNPSUPPORT BIT(11) >> +#define DWC3_GHWPARAMS6_SRPSUPPORT BIT(10) >> +#define DWC3_GHWPARAMS6_EN_FPGA BIT(7) >=20 > Keep consistency, we don't use BIT() here. >=20 Checkpatch was complaining. But I can revert to the non BIT format for consistency. cheers, -roger --nOXMLfIKmMcKFqaM1pPTwKbpRwuQBEw8M-- --HdVjA76D2Q4n7O8cRfPqEFNOXhMSeh9Fc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXZ9khAAoJENJaa9O+djCTNyoP+wVqs2J6kA8Bd7rCDwCAXYF5 ePlltgw1dLjtnRy27fllbF4ZJEQqAxnzE4ZnikPi8KdI7cjBFg5RneT9IsTkPoQ1 mZ29OZRkbnWaIIM/oWvCP6bxbqv4iWnr1Gn2Htnt794S+g/phZ23l1IiLG+DaA46 ztZat+F/8FWI9wvIpEu3BW8XeV6aPWId0luEcFEYOcRTNYXyB+krJo1tzGtyfdoH 76Wn+oRWOuNsYq8EgmgXvECxBkqRuzwaEsU2j5KxJ1ylhwieixEAUED8mo4g92ZY 9A+f8/lCGqR5U+gs6U5cMCb04moNRuk443nQkTHuPMN5uEXtS2EgGEm3pBKe+RPC 7t9qDtLzyQe9QtbsPu1JOYxfjKu/wOGuedeb0G7p2N4QgWlj3wuTrP3EGPjACX2A CPTkGstyyFqeMSdxvwvbZhOxOf4F16VwQWYvTvbYb0azIPyThPNKPuj429B7FyP6 Fwu6UEzbgdvcOLfWRV91KYApsCRm+jCXpAcmjKZJD4Da282wwU2Tj9Ea3moR/3uw wNb4RcF2YdIoTW3xiDY7Xu3kmJQLTVWtJkORWCUzMcCr0XPfp4ZYIxad1miWcdrl sC4DJzG11M5J0v4LsOYy/ClZG80x08499zLDRK22xKMaScDZ6W6tmilriBogYxOw L9bluX4nXdqCIM25cWJW =ko6w -----END PGP SIGNATURE----- --HdVjA76D2Q4n7O8cRfPqEFNOXhMSeh9Fc--