From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Chris Lapa <chris@lapa.com.au>,
dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org,
mark.rutland@arm.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm.
Date: Mon, 20 Jun 2016 14:18:03 +0200 [thread overview]
Message-ID: <5767DEFB.8010207@samsung.com> (raw)
In-Reply-To: <1466375242-38354-4-git-send-email-chris@cpdesign.com.au>
On 06/20/2016 12:27 AM, Chris Lapa wrote:
> From: Chris Lapa <chris@lapa.com.au>
>
> The max8903_charger.h file indicated that dcm and dok were not optional
> when dc_valid is set.
>
> It makes sense to have dok as a compulsory pin when dc_valid is given.
> However dcm can be optionally wired to a fixed level especially when the
> circuit is configured for dc power exclusively.
>
> The previous implementation already allowed for this somewhat, however no
> error was given if dok wasn't given whilst dc_valid was.
>
> The new implementation enforces dok presence when dc_valid is given. Whilst
> allowing dcm to be optional.
>
> Signed-off-by: Chris Lapa <chris@lapa.com.au>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
BR.
Krzysztof
next prev parent reply other threads:[~2016-06-20 12:20 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 6:44 [PATCH 0/2] max8903: Add device tree support and logic fixup chris
2016-06-02 6:44 ` [PATCH 1/2] max8903: adds support for initiation via device tree chris
2016-06-09 10:35 ` Krzysztof Kozlowski
2016-06-10 5:35 ` Chris Lapa
2016-06-10 6:13 ` Krzysztof Kozlowski
2016-06-10 10:23 ` Krzysztof Kozlowski
2016-06-02 6:44 ` [PATCH 2/2] max8903: cleans up confusing relationship between dc_valid, dok and dcm chris
2016-06-10 12:32 ` [PATCH v2 0/4] max8903: Add device tree support and logic fixup Chris Lapa
2016-06-10 12:32 ` [PATCH v2 1/4] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-10 13:51 ` Krzysztof Kozlowski
2016-06-14 1:54 ` Chris Lapa
2016-06-16 6:35 ` Krzysztof Kozlowski
2016-06-16 6:48 ` Chris Lapa
2016-06-10 12:32 ` [PATCH v2 2/4] max8903: adds support for initiation via device tree Chris Lapa
2016-06-10 14:02 ` Krzysztof Kozlowski
2016-06-14 1:50 ` Chris Lapa
2016-06-10 12:32 ` [PATCH v2 3/4] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-10 12:32 ` [PATCH v2 4/4] max8903: remove unnecessary malloc failed message print out Chris Lapa
2016-06-10 14:08 ` Krzysztof Kozlowski
2016-06-17 5:00 ` [PATCH v3 0/7] max8903: Add device tree support and misc fixes Chris Lapa
2016-06-17 5:00 ` [PATCH v3 1/7] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-17 6:15 ` Krzysztof Kozlowski
2016-06-20 13:22 ` Rob Herring
2016-06-20 23:43 ` Chris Lapa
2016-06-17 5:00 ` [PATCH v3 2/7] max8903: store pointer to pdata instead of copying it Chris Lapa
2016-06-17 6:14 ` Krzysztof Kozlowski
2016-06-17 5:00 ` [PATCH v3 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-17 6:23 ` Krzysztof Kozlowski
2016-06-17 6:26 ` Krzysztof Kozlowski
2016-06-17 6:28 ` Chris Lapa
2016-06-17 6:42 ` Krzysztof Kozlowski
2016-06-19 13:48 ` Chris Lapa
2016-06-17 5:00 ` [PATCH v3 4/7] max8903: adds requesting of gpios Chris Lapa
2016-06-17 6:30 ` Krzysztof Kozlowski
2016-06-19 13:51 ` Chris Lapa
2016-06-17 5:00 ` [PATCH v3 5/7] max8903: removes non zero validity checks on gpios Chris Lapa
2016-06-17 6:35 ` Krzysztof Kozlowski
2016-06-17 5:00 ` [PATCH v3 6/7] max8903: remove unnecessary 'out of memory' error message Chris Lapa
2016-06-17 6:35 ` Krzysztof Kozlowski
2016-06-17 5:00 ` [PATCH v3 7/7] max8903: adds support for initiation via device tree Chris Lapa
2016-06-17 6:41 ` Krzysztof Kozlowski
2016-06-19 13:52 ` Chris Lapa
2016-06-19 22:27 ` [PATCH v4 0/7] max8903: Add device tree support and misc fixes Chris Lapa
2016-06-19 22:27 ` [PATCH v4 1/7] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-20 12:17 ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 2/7] max8903: store pointer to pdata instead of copying it Chris Lapa
2016-06-20 12:18 ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-20 12:18 ` Krzysztof Kozlowski [this message]
2016-06-19 22:27 ` [PATCH v4 4/7] max8903: adds requesting of gpios Chris Lapa
2016-06-20 12:20 ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 5/7] max8903: removes non zero validity checks on gpios Chris Lapa
2016-06-20 12:21 ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 6/7] max8903: remove unnecessary 'out of memory' error message Chris Lapa
2016-06-20 12:22 ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 7/7] max8903: adds support for initiation via device tree Chris Lapa
2016-06-20 12:23 ` Krzysztof Kozlowski
2016-06-24 2:26 ` [PATCH v5 0/7] max8903: Add device tree support and misc fixes Chris Lapa
2016-06-24 2:26 ` [PATCH v5 1/7] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-28 20:55 ` Rob Herring
2016-06-24 2:26 ` [PATCH v5 2/7] max8903: store pointer to pdata instead of copying it Chris Lapa
2016-06-24 2:26 ` [PATCH v5 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-24 2:26 ` [PATCH v5 4/7] max8903: adds requesting of gpios Chris Lapa
2016-06-24 2:26 ` [PATCH v5 5/7] max8903: removes non zero validity checks on gpios Chris Lapa
2016-06-24 2:26 ` [PATCH v5 6/7] max8903: remove unnecessary 'out of memory' error message Chris Lapa
2016-06-24 2:26 ` [PATCH v5 7/7] max8903: adds support for initiation via device tree Chris Lapa
2016-06-28 18:16 ` [PATCH v5 0/7] max8903: Add device tree support and misc fixes Sebastian Reichel
2016-06-28 23:05 ` Chris Lapa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767DEFB.8010207@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=chris@lapa.com.au \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).