From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933111AbcFTRk2 (ORCPT ); Mon, 20 Jun 2016 13:40:28 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37008 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932985AbcFTRkN (ORCPT ); Mon, 20 Jun 2016 13:40:13 -0400 Subject: Re: [PATCH V2 14/63] clocksource/drivers/bcm_kona: Convert init function to return error To: Ray Jui , tglx@linutronix.de References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-15-git-send-email-daniel.lezcano@linaro.org> <707bd49d-5aea-485f-4efc-6d1d5e8d7506@broadcom.com> Cc: linux-kernel@vger.kernel.org, Florian Fainelli , Ray Jui , Scott Branden , "open list:BROADCOM BCM281XX..." From: Daniel Lezcano Message-ID: <57682A76.1070800@linaro.org> Date: Mon, 20 Jun 2016 19:40:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <707bd49d-5aea-485f-4efc-6d1d5e8d7506@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 07:22 PM, Ray Jui wrote: [ ... ] >> -static void __init kona_timer_init(struct device_node *node) >> +static int __init kona_timer_init(struct device_node *node) >> { >> u32 freq; >> struct clk *external_clk; >> >> if (!of_device_is_available(node)) { >> pr_info("Kona Timer v1 marked as disabled in device tree\n"); >> - return; >> + return 0; > > I thought we should return -ENODEV here. > > Moreover, if this device node is not enabled, kona_timer_init won't even > be invoked. Can we simply get rid of this check here? Yes, absolutely :) -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog