From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933614AbcFTUNI (ORCPT ); Mon, 20 Jun 2016 16:13:08 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:54885 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933447AbcFTUMo (ORCPT ); Mon, 20 Jun 2016 16:12:44 -0400 Subject: Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support To: Lars-Peter Clausen , Sebastian Reichel References: <20160618104038.GB31665@earth> <57684795.8050705@metafoo.de> Cc: lgirdwood@gmail.com, broonie@kernel.org, peter.ujfalusi@ti.com, jarkko.nikula@bitmer.com, k.kozlowski@samsung.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, perex@perex.cz, tiwai@suse.com, cphealy@gmail.com From: Helen Koike Message-ID: <57684E2D.8040508@collabora.co.uk> Date: Mon, 20 Jun 2016 17:12:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <57684795.8050705@metafoo.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-06-2016 16:44, Lars-Peter Clausen wrote: >> + /* before widget power up */ >> + if (SND_SOC_DAPM_EVENT_ON(event)) { >> + /* Turn on the chip */ >> + tpa6130a2_power(data, true); >> + /* Sync the registers */ >> + ret = regcache_sync(data->regmap); >> + if (ret < 0) { >> + dev_err(c->dev, "Failed to initialize chip\n"); >> + tpa6130a2_power(data, false); >> + return ret; >> + } >> + /* after widget power down */ >> + } else >> + tpa6130a2_power(data, false); > > checkpatch.pl should complain about this. Kernel code style is if one branch > has branches the other has to have it as well. > Weird, checkpatch.pl doesn't complain. I'll add the braces in v3, thank you for reviewing