From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933632AbcFTUNY (ORCPT ); Mon, 20 Jun 2016 16:13:24 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:36237 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933585AbcFTUMr (ORCPT ); Mon, 20 Jun 2016 16:12:47 -0400 Subject: Re: [PATCH V3] clocksource/drivers/bcm_kona: Convert init function to return error To: Ray Jui , tglx@linutronix.de References: <707bd49d-5aea-485f-4efc-6d1d5e8d7506@broadcom.com> <1466444880-16355-1-git-send-email-daniel.lezcano@linaro.org> <0a8c9ef4-5d38-515e-2070-10c6758aebd7@broadcom.com> Cc: linux-kernel@vger.kernel.org, f.fainelli@gmail.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com From: Daniel Lezcano Message-ID: <57684E3C.4010809@linaro.org> Date: Mon, 20 Jun 2016 22:12:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <0a8c9ef4-5d38-515e-2070-10c6758aebd7@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 07:50 PM, Ray Jui wrote: [ ... ] >> -CLOCKSOURCE_OF_DECLARE(bcm_kona, "bcm,kona-timer", kona_timer_init); >> +CLOCKSOURCE_OF_DECLARE_RET(bcm_kona, "bcm,kona-timer", kona_timer_init); > > Looks good to me! > > Acked-by: Ray Jui Can you have a quick look at the patch [63/63] for the kona part where CLOCKSOURCE_OF_DECLARE_RET is renamed back to CLOCKSOURCE_OF_DECLARE ? Thanks ! -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog