linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/8] arm64: dts: db820c: Add basic board support
@ 2016-06-20 20:01 Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
                   ` (7 more replies)
  0 siblings, 8 replies; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

Hi Andy, 

This patchset adds basic board support with uart/i2c/spi/sd card for db820c
board based on apq8096. I have tested this patchset on top of msm8996
patches at [1].
With this patchset am able to boot the board with sdcard and able to
play with i2c devices.

Thanks,
srini
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1170562.html


Srinivas Kandagatla (8):
  arm64: dts: db820c: add basic board support
  arm64: dts: db820c: add support to LS-UART0
  arm64: dts: db820c: add support to LS-I2C0
  arm64: dts: db820c: add support to LS-I2C1
  arm64: dts: db820c: add support to I2C on HS
  arm64: dts: db820c: add support to LS-SPI0
  arm64: dts: db820c: add support to SPI on HS
  arm64: dts: db820c: add support to external sd card.

 arch/arm64/boot/dts/qcom/Makefile                 |  2 +-
 arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi | 39 ++++++++++
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts       | 21 ++++++
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi      | 88 +++++++++++++++++++++++
 4 files changed, 149 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
 create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi

-- 
2.7.4

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 1/8] arm64: dts: db820c: add basic board support
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 23:23   ` Stephen Boyd
  2016-06-20 20:01 ` [PATCH 2/8] arm64: dts: db820c: add support to LS-UART0 Srinivas Kandagatla
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds apq8096 db820c basic support with serial port.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/Makefile            |  2 +-
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts  | 21 +++++++++++++++++
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++
 3 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
 create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index fa1f661..80ecdfe 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -1,5 +1,5 @@
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
-dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb apq8096-db820c.dtb
 
 always		:= $(dtb-y)
 subdir-y	:= $(dts-dirs)
diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
new file mode 100644
index 0000000..e1a55b1
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -0,0 +1,21 @@
+/*
+ * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/dts-v1/;
+
+#include "apq8096-db820c.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. DB820c";
+	compatible = "qcom,apq8096-db820c";
+};
diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
new file mode 100644
index 0000000..01916a5
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include "msm8996.dtsi"
+
+/ {
+	aliases {
+		serial0 = &blsp2_uart1;
+	};
+
+	chosen {
+		stdout-path = "serial0";
+	};
+
+	soc {
+		serial@75b0000 {
+			label = "LS-UART1";
+			status = "okay";
+			pinctrl-names = "default", "sleep";
+			pinctrl-0 = <&blsp2_uart1_2pins_default>;
+			pinctrl-1 = <&blsp2_uart1_2pins_sleep>;
+		};
+	};
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/8] arm64: dts: db820c: add support to LS-UART0
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 3/8] arm64: dts: db820c: add support to LS-I2C0 Srinivas Kandagatla
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds support to 4 pin UART0 on LS expansion connector.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index 01916a5..2851442 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -16,6 +16,7 @@
 / {
 	aliases {
 		serial0 = &blsp2_uart1;
+		serial1 = &blsp2_uart2;
 	};
 
 	chosen {
@@ -30,5 +31,13 @@
 			pinctrl-0 = <&blsp2_uart1_2pins_default>;
 			pinctrl-1 = <&blsp2_uart1_2pins_sleep>;
 		};
+
+		serial@75b1000 {
+			label = "LS-UART0";
+			status = "okay";
+			pinctrl-names = "default", "sleep";
+			pinctrl-0 = <&blsp2_uart2_4pins_default>;
+			pinctrl-1 = <&blsp2_uart2_4pins_sleep>;
+		};
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 3/8] arm64: dts: db820c: add support to LS-I2C0
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 2/8] arm64: dts: db820c: add support to LS-UART0 Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 4/8] arm64: dts: db820c: add support to LS-I2C1 Srinivas Kandagatla
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds support to LS-I2C0 on LS expansion connector.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index 2851442..0d78c4e 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -17,6 +17,7 @@
 	aliases {
 		serial0 = &blsp2_uart1;
 		serial1 = &blsp2_uart2;
+		i2c0	= &blsp1_i2c2;
 	};
 
 	chosen {
@@ -39,5 +40,12 @@
 			pinctrl-0 = <&blsp2_uart2_4pins_default>;
 			pinctrl-1 = <&blsp2_uart2_4pins_sleep>;
 		};
+
+		i2c@07577000 {
+		/* On Low speed expansion */
+			label = "LS-I2C0";
+			status = "okay";
+		};
+
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 4/8] arm64: dts: db820c: add support to LS-I2C1
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
                   ` (2 preceding siblings ...)
  2016-06-20 20:01 ` [PATCH 3/8] arm64: dts: db820c: add support to LS-I2C0 Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 5/8] arm64: dts: db820c: add support to I2C on HS Srinivas Kandagatla
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds support to LS_I2C1 on LS expansion connector.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index 0d78c4e..3114710 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -18,6 +18,7 @@
 		serial0 = &blsp2_uart1;
 		serial1 = &blsp2_uart2;
 		i2c0	= &blsp1_i2c2;
+		i2c1	= &blsp2_i2c1;
 	};
 
 	chosen {
@@ -47,5 +48,10 @@
 			status = "okay";
 		};
 
+		i2c@075b6000 {
+		/* On Low speed expansion */
+			label = "LS-I2C1";
+			status = "okay";
+		};
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 5/8] arm64: dts: db820c: add support to I2C on HS
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
                   ` (3 preceding siblings ...)
  2016-06-20 20:01 ` [PATCH 4/8] arm64: dts: db820c: add support to LS-I2C1 Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 6/8] arm64: dts: db820c: add support to LS-SPI0 Srinivas Kandagatla
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds support to i2c bus on High speed connector.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index 3114710..aefbb64 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -19,6 +19,7 @@
 		serial1 = &blsp2_uart2;
 		i2c0	= &blsp1_i2c2;
 		i2c1	= &blsp2_i2c1;
+		i2c2	= &blsp2_i2c0;
 	};
 
 	chosen {
@@ -53,5 +54,11 @@
 			label = "LS-I2C1";
 			status = "okay";
 		};
+
+		i2c@075b5000 {
+		/* On High speed expansion */
+			label = "HS-I2C2";
+			status = "okay";
+		};
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 6/8] arm64: dts: db820c: add support to LS-SPI0
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
                   ` (4 preceding siblings ...)
  2016-06-20 20:01 ` [PATCH 5/8] arm64: dts: db820c: add support to I2C on HS Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 7/8] arm64: dts: db820c: add support to SPI on HS Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
  7 siblings, 0 replies; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds support to SPI on LS expansion connector.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index aefbb64..07fe6fb 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -20,6 +20,7 @@
 		i2c0	= &blsp1_i2c2;
 		i2c1	= &blsp2_i2c1;
 		i2c2	= &blsp2_i2c0;
+		spi0	= &blsp1_spi0;
 	};
 
 	chosen {
@@ -55,6 +56,12 @@
 			status = "okay";
 		};
 
+		spi@07575000 {
+		/* On Low speed expansion */
+			label = "LS-SPI0";
+			status = "okay";
+		};
+
 		i2c@075b5000 {
 		/* On High speed expansion */
 			label = "HS-I2C2";
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 7/8] arm64: dts: db820c: add support to SPI on HS
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
                   ` (5 preceding siblings ...)
  2016-06-20 20:01 ` [PATCH 6/8] arm64: dts: db820c: add support to LS-SPI0 Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 20:01 ` [PATCH 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
  7 siblings, 0 replies; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds support to SPI on HS expansion connector.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index 07fe6fb..08b063d 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -21,6 +21,7 @@
 		i2c1	= &blsp2_i2c1;
 		i2c2	= &blsp2_i2c0;
 		spi0	= &blsp1_spi0;
+		spi1	= &blsp2_spi5;
 	};
 
 	chosen {
@@ -67,5 +68,11 @@
 			label = "HS-I2C2";
 			status = "okay";
 		};
+
+		spi@075ba000{
+		/* On High speed expansion */
+			label = "HS-SPI1";
+			status = "okay";
+		};
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 8/8] arm64: dts: db820c: add support to external sd card.
  2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
                   ` (6 preceding siblings ...)
  2016-06-20 20:01 ` [PATCH 7/8] arm64: dts: db820c: add support to SPI on HS Srinivas Kandagatla
@ 2016-06-20 20:01 ` Srinivas Kandagatla
  2016-06-20 22:53   ` kbuild test robot
  7 siblings, 1 reply; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-20 20:01 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla

This patch adds support to external sd card.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi | 39 +++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi      | 10 ++++++
 2 files changed, 49 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi
new file mode 100644
index 0000000..24552f1
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi
@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2013-2016, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+&msmgpio {
+	sdc2_cd_on: sdc2_cd_on {
+		mux {
+			pins = "gpio38";
+			function = "gpio";
+		};
+
+		config {
+			pins = "gpio38";
+			bias-pull-up;		/* pull up */
+			drive-strength = <16>;	/* 16 MA */
+		};
+	};
+
+	sdc2_cd_off: sdc2_cd_off {
+		mux {
+			pins = "gpio38";
+			function = "gpio";
+		};
+
+		config {
+			pins = "gpio38";
+			bias-pull-up;		/* pull up */
+			drive-strength = <2>;	/* 2 MA */
+		};
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index 08b063d..3fbd23e 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -12,6 +12,7 @@
  */
 
 #include "msm8996.dtsi"
+#include "apq8096-db820c-pins.dtsi"
 
 / {
 	aliases {
@@ -74,5 +75,14 @@
 			label = "HS-SPI1";
 			status = "okay";
 		};
+
+		sdhci@74A4900 {
+		/* External SD card */
+			pinctrl-names = "default", "sleep";
+			pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
+			pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
+			cd-gpios = <&msmgpio 38 0x1>;
+			status = "okay";
+		};
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 8/8] arm64: dts: db820c: add support to external sd card.
  2016-06-20 20:01 ` [PATCH 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
@ 2016-06-20 22:53   ` kbuild test robot
  0 siblings, 0 replies; 13+ messages in thread
From: kbuild test robot @ 2016-06-20 22:53 UTC (permalink / raw)
  To: Srinivas Kandagatla
  Cc: kbuild-all, Andy Gross, Rob Herring, David Brown, devicetree,
	linux-arm-kernel, linux-kernel, linux-arm-msm, linux-soc,
	Srinivas Kandagatla

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Hi,

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.7-rc4 next-20160620]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/arm64-dts-db820c-Add-basic-board-support/20160621-041430
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/qcom/apq8096-db820c-pins.dtsi:13.1-9 Label or path msmgpio not found
   FATAL ERROR: Syntax error parsing input tree

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 25985 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/8] arm64: dts: db820c: add basic board support
  2016-06-20 20:01 ` [PATCH 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
@ 2016-06-20 23:23   ` Stephen Boyd
  2016-06-21  9:14     ` Srinivas Kandagatla
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Boyd @ 2016-06-20 23:23 UTC (permalink / raw)
  To: Srinivas Kandagatla, Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc

On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote:
> This patch adds apq8096 db820c basic support with serial port.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/Makefile            |  2 +-
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts  | 21 +++++++++++++++++
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++
>  3 files changed, 56 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index fa1f661..80ecdfe 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,5 +1,5 @@
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb apq8096-db820c.dtb

We should do a new line for each board as other arm64 vendors have done?

> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> new file mode 100644
> index 0000000..e1a55b1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +
> +#include "apq8096-db820c.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. DB820c";
> +	compatible = "qcom,apq8096-db820c";

Should be qcom,apq8096-sbc? At least I have to use that on my board to
match the board ids.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/8] arm64: dts: db820c: add basic board support
  2016-06-20 23:23   ` Stephen Boyd
@ 2016-06-21  9:14     ` Srinivas Kandagatla
  2016-06-28 17:17       ` Stephen Boyd
  0 siblings, 1 reply; 13+ messages in thread
From: Srinivas Kandagatla @ 2016-06-21  9:14 UTC (permalink / raw)
  To: Stephen Boyd, Andy Gross
  Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm, linux-soc



On 21/06/16 00:23, Stephen Boyd wrote:
> On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote:
>> This patch adds apq8096 db820c basic support with serial port.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/Makefile            |  2 +-
>>   arch/arm64/boot/dts/qcom/apq8096-db820c.dts  | 21 +++++++++++++++++
>>   arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++
>>   3 files changed, 56 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>>   create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index fa1f661..80ecdfe 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -1,5 +1,5 @@
>>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
>> -dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb
>> +dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb apq8096-db820c.dtb
>
> We should do a new line for each board as other arm64 vendors have done?
I agree, Will fix this in next version.

>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> new file mode 100644 >> +/dts-v1/;
>> +
>> +#include "apq8096-db820c.dtsi"
>> +
>> +/ {
>> +	model = "Qualcomm Technologies, Inc. DB820c";
>> +	compatible = "qcom,apq8096-db820c";
>
> Should be qcom,apq8096-sbc? At least I have to use that on my board to
> match the board ids.
I agree, this should match up with the dtbTool. I have been manually 
patching up dtb to include the board-id, pmic id stuff.

I will fix it in next version,

Did not look at full details but, For some reason dtbTool does not 
support multiple compatible strings, do you think it makes sense to add 
this support in dtb tool to cope up with compatible strings like:

compatible = "qcom,apq8096-db820c", "qcom,apq8096-sbc";


Thanks,
srini
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/8] arm64: dts: db820c: add basic board support
  2016-06-21  9:14     ` Srinivas Kandagatla
@ 2016-06-28 17:17       ` Stephen Boyd
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2016-06-28 17:17 UTC (permalink / raw)
  To: Srinivas Kandagatla
  Cc: Andy Gross, Rob Herring, David Brown, devicetree,
	linux-arm-kernel, linux-kernel, linux-arm-msm, linux-soc

On 06/21, Srinivas Kandagatla wrote:
> I agree, this should match up with the dtbTool. I have been manually
> patching up dtb to include the board-id, pmic id stuff.

Uh oh :/

> 
> I will fix it in next version,
> 
> Did not look at full details but, For some reason dtbTool does not
> support multiple compatible strings, do you think it makes sense to
> add this support in dtb tool to cope up with compatible strings
> like:
> 
> compatible = "qcom,apq8096-db820c", "qcom,apq8096-sbc";
> 

Hmm I suppose we can add support to look for the first compatible
that matches something that we can generate an id for? That would
allow us to have the LK compatible and then whatever is more
specific than that which the bootloader doesn't care about.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2016-06-28 17:18 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
2016-06-20 23:23   ` Stephen Boyd
2016-06-21  9:14     ` Srinivas Kandagatla
2016-06-28 17:17       ` Stephen Boyd
2016-06-20 20:01 ` [PATCH 2/8] arm64: dts: db820c: add support to LS-UART0 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 3/8] arm64: dts: db820c: add support to LS-I2C0 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 4/8] arm64: dts: db820c: add support to LS-I2C1 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 5/8] arm64: dts: db820c: add support to I2C on HS Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 6/8] arm64: dts: db820c: add support to LS-SPI0 Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 7/8] arm64: dts: db820c: add support to SPI on HS Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
2016-06-20 22:53   ` kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).