From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696AbcFUJPI (ORCPT ); Tue, 21 Jun 2016 05:15:08 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:35449 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbcFUJO5 (ORCPT ); Tue, 21 Jun 2016 05:14:57 -0400 Subject: Re: [PATCH 1/8] arm64: dts: db820c: add basic board support To: Stephen Boyd , Andy Gross References: <1466452907-23290-1-git-send-email-srinivas.kandagatla@linaro.org> <1466452907-23290-2-git-send-email-srinivas.kandagatla@linaro.org> <57687B08.9060900@codeaurora.org> Cc: Rob Herring , David Brown , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org From: Srinivas Kandagatla Message-ID: <5769058D.9020008@linaro.org> Date: Tue, 21 Jun 2016 10:14:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <57687B08.9060900@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/16 00:23, Stephen Boyd wrote: > On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote: >> This patch adds apq8096 db820c basic support with serial port. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> arch/arm64/boot/dts/qcom/Makefile | 2 +- >> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 21 +++++++++++++++++ >> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++ >> 3 files changed, 56 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts >> create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index fa1f661..80ecdfe 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -1,5 +1,5 @@ >> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb >> -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb > > We should do a new line for each board as other arm64 vendors have done? I agree, Will fix this in next version. > >> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts >> new file mode 100644 >> +/dts-v1/; >> + >> +#include "apq8096-db820c.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. DB820c"; >> + compatible = "qcom,apq8096-db820c"; > > Should be qcom,apq8096-sbc? At least I have to use that on my board to > match the board ids. I agree, this should match up with the dtbTool. I have been manually patching up dtb to include the board-id, pmic id stuff. I will fix it in next version, Did not look at full details but, For some reason dtbTool does not support multiple compatible strings, do you think it makes sense to add this support in dtb tool to cope up with compatible strings like: compatible = "qcom,apq8096-db820c", "qcom,apq8096-sbc"; Thanks, srini >