From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751698AbcFUKPd (ORCPT ); Tue, 21 Jun 2016 06:15:33 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:42076 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbcFUKPS convert rfc822-to-8bit (ORCPT ); Tue, 21 Jun 2016 06:15:18 -0400 Message-ID: <5769139E.7020805@arm.com> Date: Tue, 21 Jun 2016 11:14:54 +0100 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yury Norov , , CC: , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 01/27] [AARCH64] Fix utmp struct for compatibility reasons. References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-2-git-send-email-ynorov@caviumnetworks.com> In-Reply-To: <1466485631-3532-2-git-send-email-ynorov@caviumnetworks.com> X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: HE1PR0401CA0033.eurprd04.prod.outlook.com (10.166.116.171) To DB5PR08MB1095.eurprd08.prod.outlook.com (10.166.174.18) X-MS-Office365-Filtering-Correlation-Id: 9988d267-9616-422f-4d6c-08d399bce7bc X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB1095;2:dI9O1wKjXqLqdnQ6RehKXxPmKk74wUciYx1PbV30mS4l3m+tfMzToJAzRbJnp0b81MAmk35koWwaVmsbPPFVQdbijIP8kppMbDOEdMYLnOb7bx8+k2XS9u7fq6tNmCxkHygTMK65xK9b7cp8PoS4sj1CxdSsbByYsEcCnWsqcERT19xppXN3et0U8lrLCLWb;3:KPB2msym0GOoagrP+52Dugq2eYNI80MICFPf0Il0ivT7pFPcVIaosLc2uksA+Snuyjo7LUWhe2rPU5/MhbIBTb/AYzh+GZYwLUdQVSrqqsc8b9+bIwDiiVO/qNmmkndk;25:ywHQIQ7rusmub5q9uSFNQQS/OlCpVXPIl6P7vJqogN45NpM3+lpZm2MPiA5Z9Di2fsKEFs/alpHcIiqbtrgQ+5t4+2M/vUK/pL8GXYt8+fXEU0QkCIjoNVa7rGBwpWKRNpwRs4iELVd6fycLzuuhxFV2heNWCZ24AyZX9CVg+0JBf3dOUYQ4aG8G3YqqeGlWIPm4ZMg2x5wQ8UIFciBldDPEIDXn/Z0OGj2SvmTAudixI/YvZHOjFipYCHgYIdjuYO0JgOZzCsdRVtPUcxgqjzGzyGX7hqs0PH/1yQVu1iag7Z0RAckDY86F6birpFKgJ1Rl8sNbxfVB/uW8HCmPKq9G20ciTeC8DQR+cJY3xuAiHGViaMQvnLgOn0zS1jOTNN+2JTqxAtb9A3FlPKwmtWJ/IefEV6Trb6V08SLh1bA=;20:qcZDgEWrd92kvxTMCmgPSDB7B3knZ4nllYaHa3Qcme61GC7l320sBvHzHAKoSp6D53O5Eyurjap7D3A+FbU40KXHyEn9OvgOLSRHToErSQWC4qaRpaRsLjEv9dT7tqeL0D2GsvaPM8VeZTcxqDUb0fv9juF6W9f0kEceAdsoml4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB1095; NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:DB5PR08MB1095;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB1095; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB1095;4:jUSgrXZDbNawgCl2pKljzzCswhUdVanXovFCVQLH/Y94dtatf79i002OZmYWKFKg6N0+aI/AAM2PRkwie6Cs0xLJffzqRd58X036ZfZZvSc3ABo1/Jnlpuhy26PXCCI5pUz8HPBXKSVgybqeItM5qMmEEaz6RgarPxMqi7fRK2Vyg2txJEIOJKa1j6sKDMPQ19YWRhjrWOMOl88RR4YVD0K54ITNHIjPckdgW4+phYZQRMhIjCcHwwhDuecLX6JDQ72QlcoLKOvjDj9cJvAP88M01fkN65882Q/FhKOn26/unBFY5XwZPDHThGiweXBmL4K87bAuB1Mf5EHtuJp6mYQ0OdUrSNbJfmOBRhJ9jJtMHwHcpgTfqXYoGeQw8XtxBGXAcm70U2bRsy0g22AQb9ByJKzpMlxkFufrNqMNuPOFyCpx4cyTLc3Z5n11Gji52qn9LAlTiGb8SsWUy/Kf7w== X-Forefront-PRVS: 098076C36C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(24454002)(189002)(199003)(50466002)(99136001)(101416001)(23746002)(76176999)(54356999)(87266999)(65816999)(50986999)(230700001)(80316001)(19580395003)(7736002)(81156014)(81166006)(7846002)(8676002)(42186005)(2906002)(4326007)(92566002)(59896002)(19580405001)(64126003)(6116002)(3846002)(586003)(36756003)(33656002)(106356001)(47776003)(68736007)(65956001)(65806001)(66066001)(105586002)(4001350100001)(2950100001)(77096005)(97736004)(5001770100001)(2201001)(83506001)(189998001)(86362001)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR08MB1095;H:[10.2.206.73];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR08MB1095;23:SaMJYYTj4EYI2e2NveBHI5MVmtCmb5SBqDAKu?= =?Windows-1252?Q?DRVblqI8NvgBANgQHEw4j47CqoW55ZQUOGeot2RBK/Ten2Dw5DtKlAKl?= =?Windows-1252?Q?cW5ELaWYE28S2QzjnKvvLYEfp4RhfLasB/mpPVO+PK3ote1tRuofw8H9?= =?Windows-1252?Q?THtUixd0uX93CiHSVsvURBTtp/yuWcK3+NLZZVcBYfYeykNWG0kHAce8?= =?Windows-1252?Q?U2mJilaGg1ZyPGpnlZdmYUKuMAVw5v21NQh8MZ0ZyaqRmy4ZPymr/r2Z?= =?Windows-1252?Q?EA/euMoupk3e8zVyoVprrciFZT5fDN+i8w1m8AfWG/eGl5Bar+XjNUCn?= =?Windows-1252?Q?CdekjigM8y9FYQFKNy7RckZWtZKTAxsKgNXFQc+G/Vgk3N06hVHQXR1l?= =?Windows-1252?Q?+IyTDdmBDL8av/i9uig5tAa7sb5G5rju76/bH4EO1sswjzQ4LGGjtS7Z?= =?Windows-1252?Q?FT/q2Xcg6Xp5dEZKa5bWEQEpZM4Pvag8bc5Wd7DJ1b5T2RnJBs7inIjU?= =?Windows-1252?Q?ingbAacGAqRQ3vjXdqhJ8baZ4DjjbE6wJWeTYe4A3PDqTsYaT+QrajU7?= =?Windows-1252?Q?BvQFBB4qhzwO6Y6dP8ksXkEJJ7jQ0G9JwROxjx4fdMf+GPp+rB5FM1k/?= =?Windows-1252?Q?OiYT5d+/OBvogKVLkQxt47pGQgL1DPAVEL1qK8ibOsR0IT1MJdFmPIPR?= =?Windows-1252?Q?aKTmXvQW+O5mEGClIC2yTRSC6mckHYzm7DTVwP/1rz8ot9Hx+SkFZVrk?= =?Windows-1252?Q?Cqr6DfWzjMp6EPdzFpDBwzffXiuG/sYqRa3CaZ+BQGqPndTpSD8IKNPH?= =?Windows-1252?Q?cD/7iUFe/LQJfwMAVPxfLWnxJsZJb1stUaRvoRHxk7UhEWmZRevf1eX2?= =?Windows-1252?Q?ybmjdytiEebEjt5kw+3kW0eQ62SNIfNntMm/65GpbOXIaPFnVllCU1Nn?= =?Windows-1252?Q?QDIHcJ+l0tbJ1q5fXxIuBpOcJRFvvICjTFZ9naBIw/DhKLt/7S3mk87M?= =?Windows-1252?Q?9gd+gwsdwvlG+LVAiTROj4a7F/eUT8qR9rLo+OUtL6CCDy2MzrZJLYfs?= =?Windows-1252?Q?7a7Y9l5DjIKjWlR9X4iXGFUZvcuuXadXiid+kKdUFFckWrl44vG/8oTb?= =?Windows-1252?Q?MhKUBoVA2JiDeUs1MPXWMOsNPHu4hITY7r1htHOlGKe5sa2gO8Br2e+f?= =?Windows-1252?Q?eX5KhU+ShLbgBe6ubL8AhEy01//og+lNfzsac9Q3jL9anckg6o779zIh?= =?Windows-1252?Q?hLh+VLplbXjDgSbXfxQ7VTyEkeqVRcy30Dz5iu0HDYCAI9SQfkdNiVRX?= =?Windows-1252?Q?EZXf7S94zDNQmdj2M4bcdfG1L+qOnAuMZF0SqHXnEwrBuWPyoCGJn18E?= =?Windows-1252?Q?PQGyu1yLI8WcREzgHxqHtrTaLy1OZik6xNJXggCcH68ApAPIvGh0BA?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB1095;6:PGRQ67/LJVr/pfsxOeNWlZVeEzqZgnrot1AIybhJL0imDefP6fkm2y2ChzUs+yoHTbexQ1lEnIECP4ILS3G+5484g/jVEvzWwDj7WbubrV54c3Lq8WdGgSoTljwZ25EHMLAl4E4SyTh7yG7tnpx+fgKg0boxdtHpZj51+O9GAge+g6A/mgvRSB6IYffIn62ctB+04PT9iYrCykUuOmWo/xACUXy7d92wvgFQeqDz3JkrVVg1aKT9zraRHBi7Z2dXZyooCd+pYRsgqjZ48TuGpoQjW31/ucYO82DpbRaWXkjibtfkeDoxf3oJDDiIghvcLYlgtpcT5KPYvoVO32fiYw==;5:VXwxFp76/1EE7tkMKLO4/CJ2m20lZ3rcONEobUbTMYAZHyOx39ea3G+YMqsbGZZbUL9gbb0p1SsOWWbNJzMTMJrmRhkardG8fzICoMM+WkX12Zor2UMknYRnmoHDgb2fc5NoK76TMX060NHRGg3rJw==;24:51qxl9i4r1KSzQgo1vq1PyLP6tPj3DW1A4B7G8mm0MIh7eA0HEYDhvAXmkAyoBG0lyDxwWH4N2qHJBoJM/iUNAxJQqJ0GD632lpfTwAA4wo=;7:0IhfEqh/6g3SCmwl679znn9YZ8OBmnSDFe4fwvBnm03poMmfo9ZRLAp0wzkR/F0ffTWkiRnyybPHUqxsLoj5uE5ksJ92atw7Isjvlk2kXBwmZp7sls1+W9zSphNas6n9/6DO9WA+8pdakokxbaIXgWLkTwMqceaeEkr5nO1InDDT+ZwHEVcyT28X2/g7upLlflLVAX45WYjb4t6E5uitQLZLfjDO4GAqNY6XRsuv9pOpUVnwDB6kh1qSer3rxr5w SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB1095;20:T3WBKzWC+TJ8EllBVUXFdORsCjTatbaCJW0HpGUHxN+96/4HeWMnwAqkmBC27sp8oaxOv1kcqzFXvlfLR9s/3KnOgM6fDyF90ZyHP2GHD9rfONoc3bb6nOEH8AmHoDIUdr3MLTnXevK11V9DMwKhMyStc3Mb2BC6xL7JVjee+nY= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2016 10:14:59.5679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB1095 X-MC-Unique: Zdm2MMCNMOqTzzZ-NqWnKw-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/16 06:06, Yury Norov wrote: > From: Andrew Pinski > > NOTE This is an ABI change for AARCH64. > If you have some AARCH32 and AARCH64 applications and they both use > utmp, one of them will fail due to the use of time_t inside the > utmp binary format. > > This fixes the problem by setting __WORDSIZE_TIME64_COMPAT32. i think changing the abi now is not ok. this is BZ 17470 and i think it should be discussed separately from ilp32. if it's possible to detect the utmp file format, that would allow a reasonable fix, the way glibc changes the struct def based on lp64 targets is non-conforming.