From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752063AbcFUMNN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 08:13:13 -0400
Received: from regular1.263xmail.com ([211.150.99.137]:58541 "EHLO
	regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751260AbcFUMNG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 08:13:06 -0400
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-ADDR-CHECKED: 0
X-RL-SENDER: zhengxing@rock-chips.com
X-FST-TO: netdev@vger.kernel.org
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: zhengxing@rock-chips.com
X-UNIQUE-TAG: <6f0f5f490f2edac7be77dce1f1d33e27>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH] net: stmmac: dwmac-rk: add rk322x-specific data
To: =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>
References: <1466493235-17789-1-git-send-email-zhengxing@rock-chips.com>
 <3520853.j0ALyW964u@diego>
Cc: linux-rockchip@lists.infradead.org, roger.chen@rock-chips.com,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        "David S. Miller" <davem@davemloft.net>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
From: Xing Zheng <zhengxing@rock-chips.com>
Message-ID: <57692F42.30709@rock-chips.com>
Date: Tue, 21 Jun 2016 20:12:50 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <3520853.j0ALyW964u@diego>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Heiko,

On 2016年06月21日 17:43, Heiko Stübner wrote:
> devicetree names are normally expected to be real, aka no "x" as catchall. So
> I guess either just add compatibles for both the rk3228 and rk3229 which point
> to the same structure in the driver. (So driver-side can stay as it is below,
> just add a second compatible).
OK, I try to just use "rockchip,rk3228-gmac" to point to "rk322x_ops" 
which is the same structure in MAC driver,
and both rk3228 and rk3229 use it.

Thanks

-- 
- Xing Zheng