linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: wim@djo.tudelft.nl
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	perex@perex.cz, linux-pci@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: kernel-4.7 bug in Intel sound and/or ACPI
Date: Tue, 21 Jun 2016 09:40:10 -0400	[thread overview]
Message-ID: <576943BA.1000001@codeaurora.org> (raw)
In-Reply-To: <20160621124715.GB3528@djo.tudelft.nl>

On 6/21/2016 8:47 AM, Wim Osterholt wrote:
>> Can you try the following and see if it makes any difference?
>>
>>
>> --- a/drivers/acpi/pci_link.c
>> +++ b/drivers/acpi/pci_link.c
>> @@ -500,7 +500,7 @@ static int acpi_irq_get_penalty(int irq)
>>         int penalty = 0;
>>
>>         if (irq < ACPI_MAX_ISA_IRQS)
>> -               penalty += acpi_isa_irq_penalty[irq];
>> +               return acpi_isa_irq_penalty[irq];
>>
>>         /*
>>         * Penalize IRQ used by ACPI SCI. If ACPI SCI pin attributes conflict
>> @@ -586,6 +586,10 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link)
>>                             acpi_device_bid(link->device));
>>                 return -ENODEV;
>>         } else {
>> +               if (irq < ACPI_MAX_ISA_IRQS)
>> +                       acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) +
>> +                                                       PIRQ_PENALTY_PCI_USING;
>> +
>>
>>
>>
>>> Bjorn
> 
> 
> I tried this on kernel 4.7.0-rc4, but that didn't help. It still tried to
> grab irq7.
> 
> 

Thanks, It was a guess with no proof.

Let's undo the change above and start adding some print statements to collect
data from your system.

Can you add this to the end of acpi_irq_get_penalty function and then send
the output?

	pr_info("%s:%d irq = %d penalty = %d\n", __func__, __LINE__, irq,
		penalty);
 


> Regards, Wim.
> 
> 
> ----- wim@djo.tudelft.nl -----
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

  reply	other threads:[~2016-06-21 13:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20  0:35 kernel-4.7 bug in Intel sound and/or ACPI Wim Osterholt
2016-06-20  1:02 ` Rafael J. Wysocki
2016-06-20 21:25   ` Bjorn Helgaas
2016-06-20 22:25     ` Sinan Kaya
2016-06-21 12:47       ` Wim Osterholt
2016-06-21 13:40         ` Sinan Kaya [this message]
2016-06-21 22:13           ` Wim Osterholt
2016-06-23  3:54             ` okaya
2016-06-23 14:12               ` Wim Osterholt
2016-06-23 14:55                 ` Sinan Kaya
2016-06-23 15:45                   ` Sinan Kaya
2016-06-23 16:21                     ` Bjorn Helgaas
2016-06-23 17:05                       ` Alex Williamson
2016-06-23 23:25                     ` Wim Osterholt
2016-06-24  6:09                       ` Sinan Kaya
2016-06-25  1:39                         ` Wim Osterholt
2016-06-25  8:51                           ` okaya
2016-06-27  6:27                             ` Wim Osterholt
2016-06-27  8:22                               ` okaya
2016-06-27 13:04                                 ` Wim Osterholt
2016-06-27 21:05                                   ` okaya
2016-06-29  8:34                                     ` Sinan Kaya
2016-06-30  2:30                                       ` Wim Osterholt
2016-06-30  9:43                                         ` okaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576943BA.1000001@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=helgaas@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rjw@rjwysocki.net \
    --cc=tiwai@suse.com \
    --cc=wim@djo.tudelft.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).