From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbcFVIHA (ORCPT ); Wed, 22 Jun 2016 04:07:00 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:47412 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbcFVIGv (ORCPT ); Wed, 22 Jun 2016 04:06:51 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfec7f4-f796c6d000001486-e0-576a4481241a Content-transfer-encoding: 8BIT Message-id: <576A447F.2020002@samsung.com> Date: Wed, 22 Jun 2016 09:55:43 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 To: Mark Rutland , Stephan Linz Cc: linux-leds@vger.kernel.org, linux-ide@vger.kernel.org, Joseph Jezak , Nico Macrionitis , =?UTF-8?B?SsO2cmcgU29tbWVy?= , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Jonathan Corbet , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' References: <20160608223000.433-1-linz@li-pro.net> <20160608223000.433-2-linz@li-pro.net> <20160621150532.GG3302@leverpostej> In-reply-to: <20160621150532.GG3302@leverpostej> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t/xK7qNLlnhBv0PmS32LvjKZPHkQDuj xfwj51gt+t8sZLU492olo8X5Ze1A1oMeZouFbUtYLI7teMRkcXnXHDaLrW/WMVpcfb2IxWLp 9YtMFhOmr2WxaN17hN2B32NJ82YmjzXz1jB6XO7rZfK4s2Udq8fl72+YPVYu/8LmsWlVJ5vH 7repHov7JrN6fN4kF8AVxWWTkpqTWZZapG+XwJXxd799wX/eiqOn5rM1MC7h7mLk5JAQMJG4 u2cSI4QtJnHh3nq2LkYuDiGBpYwSkw50sYIkeAUEJX5MvsfSxcjBwSwgL3HkUjZImFnATOJR yzpmiPpnjBLbn7RA1WtJXH83B8xmEVCVuHL0KdgCNgFDiZ8vXjOB2KICERJ/Tu8DqxERcJd4 fPAN2CBmgbPMEu2L57OAJIQF/CT+dm0DKxISqJd4fHUK2CBOAQOJ3xumsE9gFJiF5L5ZCPfN QnLfAkbmVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxghMfZlB+PiY1aHGAU4GJV4eBm6MsOF WBPLiitzDzFKcDArifCecsoKF+JNSaysSi3Kjy8qzUktPsQozcGiJM47d9f7ECGB9MSS1OzU 1ILUIpgsEwenVANjpoGXN8P5ltLqOMHH/w+Y+r/+cuKso3f0tjAW2zW7dywqaZggoGOgsDlH 5+60Q06O98u8e5YemlzQs6Ziya6l1uUsLwTn5M7KO3AqfEJ08vws1nO9q3p7PPtXrH63Sqq4 osTeIpg3dlrO3+du2h5NGdHlLY0cnftfNovnhLm/6X571NWWrVSJpTgj0VCLuag4EQD+cOon rQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/2016 05:05 PM, Mark Rutland wrote: > On Thu, Jun 09, 2016 at 12:29:37AM +0200, Stephan Linz wrote: >> Cc: Joseph Jezak >> Cc: Nico Macrionitis >> Cc: Jörg Sommer >> Signed-off-by: Stephan Linz >> --- >> Documentation/devicetree/bindings/leds/common.txt | 2 +- >> Documentation/devicetree/bindings/leds/leds-gpio.txt | 2 +- >> Documentation/laptops/asus-laptop.txt | 2 +- >> Documentation/leds/leds-class.txt | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt >> index af10678..1e97169 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -26,7 +26,7 @@ Optional properties for child nodes: >> "default-on" - LED will turn on (but for leds-gpio see "default-state" >> property in Documentation/devicetree/bindings/gpio/led.txt) >> "heartbeat" - LED "double" flashes at a load average based rate >> - "ide-disk" - LED indicates disk activity >> + "disk-activity" - LED indicates disk activity >> "timer" - LED flashes at a fixed, configurable rate > > We should not break the binding. > > Code must continue to support "ide-disk", though we can mark it > deprecated in the binding documentation, and update the in-kernel dts > files to use "disk-activity". The code in the version 4 of the patchset supports also "ide-disk". Stephan, could you send a new version of this patch, with preserved "ide-disk" property, marked as deprecated? -- Best regards, Jacek Anaszewski