From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751647AbcFWBFi (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 21:05:38 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:44964 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750850AbcFWBFg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 21:05:36 -0400
Subject: Re: [PATCH v3] cgroup: Disable IRQs while holding css_set_lock
To: Daniel Bristot de Oliveira <bristot@redhat.com>, Tejun Heo <tj@kernel.org>
References: <1466627321-22137-1-git-send-email-bristot@redhat.com>
CC: Rik van Riel <riel@redhat.com>,
        "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
        <stable@vger.kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
        Juri Lelli <juri.lelli@arm.com>, Steven Rostedt <rostedt@goodmis.org>,
        <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Zefan Li <lizefan@huawei.com>
Message-ID: <576B35C3.8070109@huawei.com>
Date: Thu, 23 Jun 2016 09:05:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1466627321-22137-1-git-send-email-bristot@redhat.com>
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.19.236]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090204.576B35D2.0009,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: effe5a4a64b1f7876ed31d74604d4076
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016/6/23 4:28, Daniel Bristot de Oliveira wrote:
> While testing the deadline scheduler + cgroup setup I hit this
> warning.
> 
...
> The warn is the spin_(lock|unlock)_bh(&css_set_lock) in the interrupt
> context. Converting the spin_lock_bh to spin_lock_irq(save) to avoid
> this problem - and other problems of sharing a spinlock with an
> interrupt.
> 
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Juri Lelli <juri.lelli@arm.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: cgroups@vger.kernel.org
> Cc: stable@vger.kernel.org # 4.5+
> Cc: linux-kernel@vger.kernel.org
> Reviewed-by: Rik van Riel <riel@redhat.com>
> Reviewed-by: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> 

Acked-by: Zefan Li <lizefan@huawei.com>