From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Johnny Kim <johnny.kim@atmel.com>,
Austin Shin <austin.shin@atmel.com>,
Chris Park <chris.park@atmel.com>, Tony Cho <tony.cho@atmel.com>,
Glen Lee <glen.lee@atmel.com>, Leo Kim <leo.kim@atmel.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()
Date: Thu, 23 Jun 2016 12:25:47 +0100 [thread overview]
Message-ID: <576BC73B.9070503@osg.samsung.com> (raw)
In-Reply-To: <CAGRGNgUoptASqK7jD-K-=zp7eYbJDq+2+u7mj_MabaGtOb9=kQ@mail.gmail.com>
On 23/06/16 02:29, Julian Calaby wrote:
> Hi All,
>
> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
> <luisbg@osg.samsung.com> wrote:
>> The common format to check if a function returned an error pointer is to
>> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>>
>> Also, if there was an error returning -EINVAL instead of -1 is more
>> appropriate.
>
> These two changes could be argued to be separate changes deserving of
> their own patches.
>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>
> However if everyone else is ok with that, this is:
>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
>
> Thanks,
>
Hi Julian,
If you don't mind I will resend as two separate patches and include your
Reviewed-by in both.
Thanks for the review,
Luis
next prev parent reply other threads:[~2016-06-23 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 12:39 [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init() Luis de Bethencourt
2016-06-23 1:29 ` Julian Calaby
2016-06-23 11:25 ` Luis de Bethencourt [this message]
2016-06-23 11:29 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576BC73B.9070503@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=julian.calaby@gmail.com \
--cc=leo.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).