From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbcFWMvK (ORCPT ); Thu, 23 Jun 2016 08:51:10 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36879 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbcFWMvI (ORCPT ); Thu, 23 Jun 2016 08:51:08 -0400 Subject: Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit To: Jassi Brar References: <1466503374-28841-1-git-send-email-narmstrong@baylibre.com> <1466503374-28841-2-git-send-email-narmstrong@baylibre.com> Cc: "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , Sudeep Holla , =?UTF-8?Q?Heiko_St=c3=bcbner?= , frank.wang@rock-chips.com, khilman@baylibre.com, linux-amlogic@lists.infradead.org, Caesar Wang From: Neil Armstrong Organization: Baylibre Message-ID: <576BDB2F.2070003@baylibre.com> Date: Thu, 23 Jun 2016 14:50:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/22/2016 06:31 AM, Jassi Brar wrote: > On Tue, Jun 21, 2016 at 3:32 PM, Neil Armstrong wrote: >> Add Amlogic Meson SoCs Message-Handling-Unit as mailbox controller >> with 2 independent channels/links to communicate with a remote processor. >> >> Signed-off-by: Neil Armstrong > > ..... > >> +++ b/drivers/mailbox/meson_mhu.c >> @@ -0,0 +1,199 @@ >> +/* >> + * Copyright (C) 2016 BayLibre SAS. >> + * Author: Neil Armstrong >> + * Heavily based on meson_mhu.c from : >> + * Copyright (C) 2013-2015 Fujitsu Semiconductor Ltd. >> + * Copyright (C) 2015 Linaro Ltd. >> + * Author: Jassi Brar > > ......... >> + >> +#define INTR_SET_OFS 0x0 >> +#define INTR_STAT_OFS 0x4 >> +#define INTR_CLR_OFS 0x8 >> + >> +#define MHU_LP_OFFSET 0x10 >> +#define MHU_HP_OFFSET 0x1c >> + >> +#define TX_REG_OFFSET 0x24 >> + > It seems only some register offsets have changed from arm_mhu. So > maybe just adapt the arm_mhu driver to look for IP variant and assign > corresponding offsets to set,stat,clr registers. Hi Jassi, It's a good idea, but adding the platform_driver support along the amba_bus probe will add a lot a code. The meson_mhu is a very simple and short driver, I think it'll be simpler to maintain beeing separated. And I'm not certain on how it's close of ARM's real IP. Neil > Cheers. >