From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
Mugunthan V N <mugunthanvnm@ti.com>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc
Date: Fri, 24 Jun 2016 19:58:32 +0300 [thread overview]
Message-ID: <576D66B8.7040300@ti.com> (raw)
In-Reply-To: <20160624161541.GA23499@csclub.uwaterloo.ca>
On 06/24/2016 07:15 PM, Lennart Sorensen wrote:
> On Fri, Jun 24, 2016 at 11:35:15AM +0530, Mugunthan V N wrote:
>>>> +static void cpdma_desc_pool_destroy(struct cpdma_desc_pool *pool)
>>>> +{
>>>> + if (!pool)
>>>> + return;
>>>> +
>>>> + WARN_ON(pool->used_desc);
>>>> + if (pool->cpumap) {
>>>> + dma_free_coherent(pool->dev, pool->mem_size, pool->cpumap,
>>>> + pool->phys);
>>>> + } else {
>>>> + iounmap(pool->iomap);
>>>> + }
>>>> +}
>>>> +
>>> single if, brackets?
>>
>> if() has multiple line statement, so brackets are must.
>
> It is line wrapped, it is still one statement. And you can't argue the
> else being multiple lines, although the style does require using brackets
> for the else if the if required them.
>
> Style says "Do not unnecessarily use braces where a single statement will do."
> It says statement, not line. A multiline wrapped statement is still
> one statement.
>
> I may personally hate the lack of brackets, but style wise it seems very
> clear that the linux kernel only uses brakcets when required, which is
> only when there is more than one statement. I prefer what you did,
> but not as much as I prefer consistency.
>
Oh. nice :( So, seems, I'd need to send v3. Right?
By the way, this code hasn't been introduced by this patch - I've
just moved whole function from one place to another.
--
regards,
-grygorii
next prev parent reply other threads:[~2016-06-24 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 12:36 [PATCH] net: ethernet: ti: cpdma: switch to use genalloc Grygorii Strashko
2016-06-23 12:56 ` Ivan Khoronzhuk
2016-06-24 6:05 ` Mugunthan V N
2016-06-24 11:57 ` Afzal Mohammed
2016-06-24 16:15 ` Lennart Sorensen
2016-06-24 16:58 ` Grygorii Strashko [this message]
2016-06-24 18:39 ` Lennart Sorensen
2016-06-25 8:33 ` Afzal Mohammed
2016-06-23 13:17 ` ivan.khoronzhuk
2016-06-24 6:03 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576D66B8.7040300@ti.com \
--to=grygorii.strashko@ti.com \
--cc=davem@davemloft.net \
--cc=ivan.khoronzhuk@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).