From: "Andrew F. Davis" <afd@ti.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Laxman Dewangan <ldewangan@nvidia.com>,
<linux-hwmon@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors
Date: Fri, 24 Jun 2016 12:30:56 -0500 [thread overview]
Message-ID: <576D6E50.6000604@ti.com> (raw)
In-Reply-To: <20160624164651.GB21447@roeck-us.net>
On 06/24/2016 11:46 AM, Guenter Roeck wrote:
> On Fri, Jun 24, 2016 at 10:02:51AM -0500, Andrew F. Davis wrote:
>> On 06/18/2016 10:16 AM, Guenter Roeck wrote:
>>>
>>> The chip registers are 16 bit. Can you repeat the command using the "w"
>>> option ?
>>>
>>
>> # i2cdump -y 2 0x40 w
>> 0,8 1,9 2,a 3,b 4,c 5,d 6,e 7,f
>> 00: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 08: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 10: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 18: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 20: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 28: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 30: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 38: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 40: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 48: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 50: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 58: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 60: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 68: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 70: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 78: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 80: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 88: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 90: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 98: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> a0: 2771 0000 0000 0000 0000 0000 0000 f87f
>> a8: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> b0: 1027 2823 ffff ffff ffff ffff ffff ffff
>> b8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> c0: 2771 0000 0000 0000 0000 0000 0000 f87f
>> c8: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> d0: 1027 2823 ffff ffff ffff ffff ffff ffff
>> d8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> e0: 2771 0000 0000 0000 0000 0000 0000 f87f
>> e8: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> f0: 1027 2823 ffff ffff ffff ffff ffff ffff
>> f8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>
> Thanks a lot!
>
Feel free to completely ignore the first register dump I sent, I did it
for the wrong device anyway :).
I had just gotten done reading this:
https://lkml.org/lkml/2015/12/10/459
and accidentally got EVMs confused did the test for the TMP461, but it
does look like on startup register 0x16 can be used to differentiate the
parts, if the TMP461 hadn't gone into a different driver.
Andrew
next prev parent reply other threads:[~2016-06-24 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 15:32 [PATCH v5 0/1] Add support for INA3221 Triple Current/Voltage Monitors Andrew F. Davis
2016-06-10 15:32 ` [PATCH v5 1/1] hwmon: " Andrew F. Davis
2016-06-10 16:44 ` Guenter Roeck
2016-06-17 23:21 ` Andrew F. Davis
2016-06-18 15:16 ` Guenter Roeck
2016-06-24 15:02 ` Andrew F. Davis
2016-06-24 16:46 ` Guenter Roeck
2016-06-24 17:30 ` Andrew F. Davis [this message]
2016-06-24 20:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576D6E50.6000604@ti.com \
--to=afd@ti.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).