From: Sudeep Holla <sudeep.holla@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Vikas Sajjan <vikas.cha.sajjan@hpe.com>, Sunil <sunil.vl@hpe.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Prashanth Prakash <pprakash@codeaurora.org>,
Al Stone <al.stone@linaro.org>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 5/5] ACPI : enable ACPI_PROCESSOR_IDLE on ARM64
Date: Mon, 27 Jun 2016 16:03:31 +0100 [thread overview]
Message-ID: <57714043.5020207@arm.com> (raw)
In-Reply-To: <5771392B.3080002@linaro.org>
Hi Daniel,
On 27/06/16 15:33, Daniel Lezcano wrote:
> On 06/14/2016 04:48 PM, Sudeep Holla wrote:
>> Now that ACPI processor idle driver supports LPI(Low Power Idle), lets
>> enable ACPI_PROCESSOR_IDLE for ARM64 too.
>>
>> This patch just removes the IA64 and X86 dependency on
>> ACPI_PROCESSOR_IDLE
>>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>
> Hi Sudeep,
>
> now that ACPI processor supports ARM64 did you check the
> CPUIDLE_DRIVER_STATE_START trick in the code and its derivative ?
>
No, that is used only for C-State and ARM64 doesn't support it.
Patch 1/5 puts all the C-State code under #ifdef so that it's not
compiled on ARM64.
> I deleted the patch 2/5 but there is a place where:
>
Sorry, I don't follow what you mean by that.
> if (max_cstate=0)
> max_cstate=1;
>
> Probably this is because the POLL state is inserted, so there is always
> an idle state. But for ARM, that is not the case.
>
Yes
> Also, there are some places where the idle state index begins to 1. I
> think it should be 0 for ARM.
>
Yes for LPI, it does start from 0.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-06-27 15:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 14:48 [PATCH v6 0/5] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 1/5] ACPI / processor_idle: introduce ACPI_PROCESSOR_CSTATE Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 2/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states Sudeep Holla
2016-06-14 16:47 ` Sudeep Holla
2016-06-14 16:54 ` [PATCH v6 2/5][UPDATED] " Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 3/5] arm64: cpuidle: drop __init section marker to arm_cpuidle_init Sudeep Holla
2016-06-22 16:09 ` Lorenzo Pieralisi
2016-06-14 14:48 ` [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla
2016-06-22 14:17 ` Lorenzo Pieralisi
2016-06-24 21:04 ` Daniel Lezcano
2016-06-24 22:47 ` Rafael J. Wysocki
2016-06-25 8:05 ` Daniel Lezcano
2016-06-27 9:50 ` Sudeep Holla
2016-06-27 16:29 ` Daniel Lezcano
2016-06-27 17:07 ` Sudeep Holla
2016-06-27 17:58 ` Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 5/5] ACPI : enable ACPI_PROCESSOR_IDLE on ARM64 Sudeep Holla
2016-06-27 14:33 ` Daniel Lezcano
2016-06-27 15:03 ` Sudeep Holla [this message]
2016-06-27 15:05 ` Daniel Lezcano
2016-06-27 15:06 ` Sudeep Holla
2016-06-27 15:08 ` Daniel Lezcano
2016-06-27 15:11 ` Sudeep Holla
2016-06-27 15:12 ` Daniel Lezcano
2016-06-22 17:45 ` [PATCH v6 0/5] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla
2016-06-23 0:42 ` Rafael J. Wysocki
2016-06-25 0:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57714043.5020207@arm.com \
--to=sudeep.holla@arm.com \
--cc=al.stone@linaro.org \
--cc=ashwin.chaugule@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pprakash@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=sunil.vl@hpe.com \
--cc=vikas.cha.sajjan@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).