From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070AbcF1HNk (ORCPT ); Tue, 28 Jun 2016 03:13:40 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:14007 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbcF1HNi (ORCPT ); Tue, 28 Jun 2016 03:13:38 -0400 Message-ID: <57722395.8080706@bfs.de> Date: Tue, 28 Jun 2016 09:13:25 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Christophe JAILLET CC: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: echoaudio: Fix memory allocation References: <1467054411-19752-1-git-send-email-christophe.jaillet@wanadoo.fr> In-Reply-To: <1467054411-19752-1-git-send-email-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.06.2016 21:06, schrieb Christophe JAILLET: > 'commpage_bak' is allocated with 'sizeof(struct echoaudio)' bytes. > We then copy 'sizeof(struct comm_page)' bytes in it. > On my system, smatch complains because one is 2960 and the other is 3072. > > This would result in memory corruption or a oops. > > Signed-off-by: Christophe JAILLET > --- > sound/pci/echoaudio/echoaudio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c > index 1cb85ae..286f5e3 100644 > --- a/sound/pci/echoaudio/echoaudio.c > +++ b/sound/pci/echoaudio/echoaudio.c > @@ -2200,11 +2200,11 @@ static int snd_echo_resume(struct device *dev) > u32 pipe_alloc_mask; > int err; > > - commpage_bak = kmalloc(sizeof(struct echoaudio), GFP_KERNEL); > + commpage_bak = kmalloc(sizeof(*commpage), GFP_KERNEL); > if (commpage_bak == NULL) > return -ENOMEM; > commpage = chip->comm_page; > - memcpy(commpage_bak, commpage, sizeof(struct comm_page)); > + memcpy(commpage_bak, commpage, sizeof(*commpage)); > > err = init_hw(chip, chip->pci->device, chip->pci->subsystem_device); > if (err < 0) { perhaps you can use here kmemdup() ? re, wh