From: Wei Xu <xuwei5@hisilicon.com>
To: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Guodong Xu <guodong.xu@linaro.org>, <xuwei5@hisilicon.com>
Subject: Re: [RESEND][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support
Date: Tue, 28 Jun 2016 19:18:34 +0100 [thread overview]
Message-ID: <5772BF7A.3020700@hisilicon.com> (raw)
In-Reply-To: <1466714368-4813-3-git-send-email-john.stultz@linaro.org>
Hi John,
On 23/06/2016 21:39, John Stultz wrote:
> From: Zhangfei Gao <zhangfei.gao@linaro.org>
>
> Add pl031 rtc0 and rtc1 support to hi6220 dtsi
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> [jstultz: Forward ported and tweaked commit description,
> added rtc1 entry as suggested by Guodong]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 189d215..12510b5 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -336,6 +336,22 @@
> clock-names = "timer1", "timer2", "apb_pclk";
> };
>
> + rtc0: rtc@f8003000 {
> + compatible = "arm,pl031", "arm,primecell";
> + reg = <0x0 0xf8003000 0x0 0x1000>;
> + interrupts = <0 12 4>;
> + clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
> + clock-names = "apb_pclk";
> + };
> +
> + rtc1: rtc@f8004000 {
Sorry for the late reply.
Thanks for the patch!
Except the indent of the rtc1, the others is fine to me.
Acked-by: Wei Xu <xuwei5@hisilicon.com>
As what Stephen said in the cover letter works for me.
Best Regards,
Wei
> + compatible = "arm,pl031", "arm,primecell";
> + reg = <0x0 0xf8004000 0x0 0x1000>;
> + interrupts = <0 8 4>;
> + clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
> + clock-names = "apb_pclk";
> + };
> +
> pmx0: pinmux@f7010000 {
> compatible = "pinctrl-single";
> reg = <0x0 0xf7010000 0x0 0x27c>;
>
next prev parent reply other threads:[~2016-06-28 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 20:39 [RESEND][PATCH 0/2] Add pl031 RTC support for Hi6220/HiKey John Stultz
2016-06-23 20:39 ` [RESEND][PATCH 1/2] clk: hi6220: Add RTC clock for pl031 John Stultz
2016-06-23 20:39 ` [RESEND][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support John Stultz
2016-06-28 18:18 ` Wei Xu [this message]
2016-06-24 4:38 ` [RESEND][PATCH 0/2] Add pl031 RTC support for Hi6220/HiKey Rob Herring
2016-06-28 17:15 ` Stephen Boyd
2016-06-30 0:30 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5772BF7A.3020700@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).