From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752224AbcF2FEt (ORCPT ); Wed, 29 Jun 2016 01:04:49 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:41096 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbcF2FEs (ORCPT ); Wed, 29 Jun 2016 01:04:48 -0400 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: neidhard.kim@lge.com X-Original-SENDERIP: 10.178.37.74 X-Original-MAILFROM: neidhard.kim@lge.com Subject: Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags To: Rob Herring References: <20160621005910.GN1521@codeaurora.org> <1466741572-58802-1-git-send-email-neidhard.kim@lge.com> <20160628205518.GF3737@rob-hp-laptop> Cc: Maxime Ripard , Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chanho Min From: Jongsung Kim Message-ID: <577356E8.30009@lge.com> Date: Wed, 29 Jun 2016 14:04:40 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160628205518.GF3737@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 06월 29일 05:55, Rob Herring wrote: > On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote: >> There is no way to set additional flags for a DT-initialized fixed- >> factor-clock, and it can be problematic i.e., when the clock rate >> needs to be changed. [1][2] >> >> This patch introduces an optional dt-binding named "clock-flags" to >> be used for passing any needed flags from dts. > I don't think we want this in DT. If we did, the flags would need some > documentation about what the flags mean. Thanks for your comment. It looks not that big deal to provide a little documentation..? Some of the flags looks safe to be removed. Thinking of only fixed-factor-clock, most of them can be removed.