From: Sudeep Holla <sudeep.holla@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-kernel@lists.infradead.org
Cc: Sudeep Holla <sudeep.holla@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] coresight: add PM runtime calls to coresight_simple_func()
Date: Thu, 30 Jun 2016 16:37:32 +0100 [thread overview]
Message-ID: <57753CBC.7070905@arm.com> (raw)
In-Reply-To: <1466780963-21396-1-git-send-email-mathieu.poirier@linaro.org>
On 24/06/16 16:09, Mathieu Poirier wrote:
> It is mandatory to enable a coresight block's power domain before
> trying to access management registers. Otherwise the transaction
> simply stalls, leading to a system hang.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> Change from V1:
> - Fix erroneous return point in the macro.
>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> drivers/hwtracing/coresight/coresight-priv.h | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
> index ad975c58080d..decfd52b5dc3 100644
> --- a/drivers/hwtracing/coresight/coresight-priv.h
> +++ b/drivers/hwtracing/coresight/coresight-priv.h
> @@ -16,6 +16,7 @@
> #include <linux/bitops.h>
> #include <linux/io.h>
> #include <linux/coresight.h>
> +#include <linux/pm_runtime.h>
>
> /*
> * Coresight management registers (0xf00-0xfcc)
> @@ -42,8 +43,11 @@ static ssize_t name##_show(struct device *_dev, \
> struct device_attribute *attr, char *buf) \
> { \
> type *drvdata = dev_get_drvdata(_dev->parent); \
> - return scnprintf(buf, PAGE_SIZE, "0x%x\n", \
> - readl_relaxed(drvdata->base + offset)); \
> + u32 val; \
> + pm_runtime_get_sync(_dev->parent); \
> + val = readl_relaxed(drvdata->base + offset); \
> + pm_runtime_put_sync(_dev->parent); \
> + return scnprintf(buf, PAGE_SIZE, "0x%x\n", val); \
> } \
> static DEVICE_ATTR_RO(name)
>
>
prev parent reply other threads:[~2016-06-30 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 15:09 [PATCH V2] coresight: add PM runtime calls to coresight_simple_func() Mathieu Poirier
2016-06-30 15:37 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57753CBC.7070905@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).