From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 179FAC43603 for ; Mon, 9 Dec 2019 11:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8E4B2077B for ; Mon, 9 Dec 2019 11:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727608AbfLILws (ORCPT ); Mon, 9 Dec 2019 06:52:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:44330 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727074AbfLILwr (ORCPT ); Mon, 9 Dec 2019 06:52:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1E517B15F; Mon, 9 Dec 2019 11:52:17 +0000 (UTC) Subject: Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Boris Ostrovsky References: <20191205140123.3817-1-pdurrant@amazon.com> <20191205140123.3817-4-pdurrant@amazon.com> <20191209114137.GT980@Air-de-Roger> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <5777c17b-9028-2525-1322-6c05f1ce3aab@suse.com> Date: Mon, 9 Dec 2019 12:52:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191209114137.GT980@Air-de-Roger> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.12.19 12:41, Roger Pau Monné wrote: > On Thu, Dec 05, 2019 at 02:01:22PM +0000, Paul Durrant wrote: >> Currently these macros will skip over any requests/responses that are >> added to the shared ring whilst it is detached. This, in general, is not >> a desirable semantic since most frontend implementations will eventually >> block waiting for a response which would either never appear or never be >> processed. >> >> NOTE: These macros are currently unused. BACK_RING_ATTACH(), however, will >> be used in a subsequent patch. >> >> Signed-off-by: Paul Durrant > > Those headers come from Xen, and should be modified in Xen first and > then imported into Linux IMO. In theory, yes. But the Xen variant doesn't contain the ATTACH macros. Juergen