From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbcGFEJs (ORCPT ); Wed, 6 Jul 2016 00:09:48 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:60915 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbcGFEJn (ORCPT ); Wed, 6 Jul 2016 00:09:43 -0400 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: check only data or node for summary To: Jaegeuk Kim , , , References: <20160610210107.74181-1-jaegeuk@kernel.org> CC: Bintian From: He YunLei Message-ID: <577C8468.3060503@huawei.com> Date: Wed, 6 Jul 2016 12:09:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160610210107.74181-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.64.133] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.577C8480.00DA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: a27544a37a48f8b7cc573ebce237d2f6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/6/11 5:01, Jaegeuk Kim wrote: > We can check data or node types only for gc, since we allocate different type of > data/node blocks in a different logs occasionally. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index e1d274c..c2c4ac3 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -806,7 +806,8 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, > f2fs_put_page(sum_page, 0); > > sum = page_address(sum_page); > - f2fs_bug_on(sbi, type != GET_SUM_TYPE((&sum->footer))); > + f2fs_bug_on(sbi, IS_DATASEG(type) != > + IS_DATASEG(GET_SUM_TYPE((&sum->footer)))); Hi, Kim type has been transformed into SUM_TYPE_DATA or SUM_TYPE_NODE, so here no need to do this. Thanks > > /* > * this is to avoid deadlock: >