From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbcGFJnM (ORCPT ); Wed, 6 Jul 2016 05:43:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:35505 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbcGFJnJ (ORCPT ); Wed, 6 Jul 2016 05:43:09 -0400 Subject: Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR To: Johannes Thumshirn , James Bottomley , "Martin K . Petersen" References: <1467791510-5307-1-git-send-email-jthumshirn@suse.de> Cc: Linux SCSI Mailinglist , Linux Kernel Mailinglist From: Hannes Reinecke Message-ID: <577CD2AA.3080204@suse.de> Date: Wed, 6 Jul 2016 11:43:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1467791510-5307-1-git-send-email-jthumshirn@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2016 09:51 AM, Johannes Thumshirn wrote: > qla2xxx first calls request_irq() and then does the setup of the queue > entry data needed in the interrupt handlers in when using MSI-X. This > could lead to a NULL pointer dereference when an IRQ fires between the > request_irq() call and the assignment of the qentry data structure to the > rsp->msix field. A possible case for such a race would be in the kdump > case when the HBA's IRQs are still enabled but the driver is undergoing > a new initialisation and thus is not aware of already activated IRQs in > the HBA. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/qla2xxx/qla_isr.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)