From: Sudeep Holla <sudeep.holla@arm.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
ACPI List <linux-acpi@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Vikas Sajjan <vikas.cha.sajjan@hpe.com>, Sunil <sunil.vl@hpe.com>,
PrashanthPrakash <pprakash@codeaurora.org>,
Al Stone <al.stone@linaro.org>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
ALKML <linux-arm-kernel@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v8 5/6] arm64: add support for ACPI Low Power Idle(LPI)
Date: Fri, 8 Jul 2016 16:21:51 +0100 [thread overview]
Message-ID: <577FC50F.7010205@arm.com> (raw)
In-Reply-To: <20160708144719.GI3784@red-moon>
On 08/07/16 15:47, Lorenzo Pieralisi wrote:
> On Thu, Jul 07, 2016 at 06:10:50PM +0100, Sudeep Holla wrote:
>> This patch adds appropriate callbacks to support ACPI Low Power Idle
>> (LPI) on ARM64.
>>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>> arch/arm64/kernel/cpuidle.c | 18 +++++++
>> drivers/firmware/psci.c | 122 ++++++++++++++++++++++++++++++++++++--------
>
> I would split this patch in two (ARM64 cpuidle and PSCI)
Agreed, I combined it to get it functional in one go, but until we have
6/6, it won't work. So better to split that changes.
> and for
> the PSCI code (apologies, blame taken, it is entirely my fault) I
> think that the code in v6 was better, I asked you to factor out
> DT/ACPI idle states count and parameter retrieval but the end result
> is much more complicated than what it was in v6, so for PSCI ACPI
> idle states parsing I would revert to v6, apologies.
>
Yes I agree it got bit complicated. I will revert back to v6 for that part.
> With changes above:
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
Thanks
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-07-08 15:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 17:10 [PATCH v8 0/6] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla
2016-07-07 17:10 ` [PATCH v8 1/6] ACPI / processor_idle: introduce ACPI_PROCESSOR_CSTATE Sudeep Holla
2016-07-07 17:10 ` [PATCH v8 2/6] ACPI / processor_idle: Add support for Low Power Idle(LPI) states Sudeep Holla
2016-07-07 17:10 ` [PATCH v8 3/6] arm64: cpuidle: drop __init section marker to arm_cpuidle_init Sudeep Holla
2016-07-07 17:10 ` [PATCH v8 4/6] cpuidle: introduce CPU_IDLE_ENTER_WRAPPED macro for ARM{32,64} Sudeep Holla
2016-07-07 17:10 ` [PATCH v8 5/6] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla
2016-07-07 17:10 ` [PATCH v8 6/6] ACPI : enable ACPI_PROCESSOR_IDLE on ARM64 Sudeep Holla
2016-07-08 14:47 ` [PATCH v8 5/6] arm64: add support for ACPI Low Power Idle(LPI) Lorenzo Pieralisi
2016-07-08 15:21 ` Sudeep Holla [this message]
2016-07-07 21:02 ` [PATCH v8 0/6] ACPI / processor_idle: Add ACPI v6.0 LPI support Rafael J. Wysocki
2016-07-08 11:04 ` Sudeep Holla
2016-07-08 14:43 ` Lorenzo Pieralisi
2016-07-08 15:19 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577FC50F.7010205@arm.com \
--to=sudeep.holla@arm.com \
--cc=al.stone@linaro.org \
--cc=ashwin.chaugule@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=pprakash@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=sunil.vl@hpe.com \
--cc=vikas.cha.sajjan@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).