From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757484AbcGKCTN (ORCPT ); Sun, 10 Jul 2016 22:19:13 -0400 Received: from m199-177.yeah.net ([123.58.177.199]:63901 "EHLO m199-177.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757265AbcGKCTJ (ORCPT ); Sun, 10 Jul 2016 22:19:09 -0400 Subject: Re: [PATCH v2 02/10] irqchip: add irqchip driver for nuc900 To: Paul Gortmaker References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-3-git-send-email-vw@iommu.org> Cc: devicetree@vger.kernel.org, Jason Cooper , Arnd Bergmann , Daniel Lezcano , Russell King , LKML , p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" From: Wan Zongshun Message-ID: <57830217.3030800@iommu.org> Date: Mon, 11 Jul 2016 10:19:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZIVUhISUJCQkJPT01DTUNDQk1XWQkOFx4IWU FZKCs9JDU0NT4kMjUkMz46Pz4pQUtVS0A2IyQiPigkMjUkMz46Pz4pQUtVS0ArLykkNTQkMjUkMz 46Pz4pQUtVS0A4NC41LykiJDg1QUtVS0ApPjwyNDUkOigyOkFLVUtAKyk0LTI1OD4kKDM6NTwzOj JBS1VLQD8iNTo2MjgkMiskNTQkMjUkMz46Pz4pQUtVS0A2LjcvMiQpOCsvJD8yPT0#KT41LyQyNS QzPjo*PilBSVVLQDIrJC80PzoiJDg1LyRLJEpLS0FLVUtAMiskSiQ2MjUuLz4kODUvJEskSktBS1 VLQDIrJEhLJDYyNS4vPiQ4NS8kSyROS0FLVUtAMiskTiQ2MjUuLz4kODUvJEskSktBS1VLQDIrJE okMzQuKSQ4NS8kSyRKS0tBS1VLQCguOTE#OC8kLzQ*OiIkODUvJEskSktLQUtVS0AoLjkxPjgvJE okMzQuKSQ4NS8kSyRKS0tBS1VLQCguOTE#OC8kTiQ2MjUuLz4kODUvJEskSktBS1VLQCg5MSQ3Pj UkT0skI0FLVUtLSktALz4jLyQ3PjUkSklDSyQjQUtVS0tKS0A4NS8kMy82NyQ3PjUkSjAkTjBBS1 VLS0pLQCk#OD4yLT4pJDg1LyROJCNBS1VLS0pLQCM2OjI3PikkNS43N0FLVUtLSktAPz43Mi0#KS Q3PjUkS0FLVUtLSktANzo1PCQ#NUFLVUtLSktAPTUkNjoiJE9KQiQzNzEkSiRLQ0tIS09BS1VISE A9KyQpPiQ9LCQzNzEkS0NLSEtNQVZMVU5APTUkKC45JD41LDQpPygkMzcxJEpLS0lLSkFLVUlDQC guOSQ#QUpVTk5APTUkNjoiJE9KQiQzNzEkSSRLQ0tIS09BS1VLWQY+ X-HM-Sender-Digest: e1kSHx4VD1lBWUc6NUk6LRw6NTosEDICKlY9ExY5TQ8KCy1VSlVKT01D SUtITk9PSEhMVTMWGhIXVQ0MOxIUFhYOVRQJHEVZV1kMHhlZQR0aFwgeV1kIAVlBTkpJTDdXWRIL WUFZSUpLVUpIVUJMVUpNQ1kG X-HM-Tid: 0a55d7c02e8d64279b0681102e10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年07月11日 05:51, Paul Gortmaker wrote: > On Sun, Jul 10, 2016 at 3:27 AM, Wan Zongshun wrote: >> This patch is to add irqchip driver support for nuc900 plat, >> current this driver only supports nuc970 SoC. >> >> Signed-off-by: Wan Zongshun >> --- >> arch/arm/mach-w90x900/include/mach/irqs.h | 5 + >> drivers/irqchip/Makefile | 1 + >> drivers/irqchip/irq-nuc900.c | 150 ++++++++++++++++++++++++++++++ >> 3 files changed, 156 insertions(+) >> create mode 100644 drivers/irqchip/irq-nuc900.c >> >> diff --git a/arch/arm/mach-w90x900/include/mach/irqs.h b/arch/arm/mach-w90x900/include/mach/irqs.h >> index 9d5cba3..3b035c6 100644 >> --- a/arch/arm/mach-w90x900/include/mach/irqs.h >> +++ b/arch/arm/mach-w90x900/include/mach/irqs.h >> @@ -59,7 +59,12 @@ >> #define IRQ_KPI W90X900_IRQ(29) >> #define IRQ_P2SGROUP W90X900_IRQ(30) >> #define IRQ_ADC W90X900_IRQ(31) >> + >> +#if !defined(CONFIG_SOC_NUC900) >> #define NR_IRQS (IRQ_ADC+1) >> +#else >> +#define NR_IRQS 62 >> +#endif >> >> /*for irq group*/ >> >> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile >> index 38853a1..9ccd5af8a 100644 >> --- a/drivers/irqchip/Makefile >> +++ b/drivers/irqchip/Makefile >> @@ -69,3 +69,4 @@ obj-$(CONFIG_PIC32_EVIC) += irq-pic32-evic.o >> obj-$(CONFIG_MVEBU_ODMI) += irq-mvebu-odmi.o >> obj-$(CONFIG_LS_SCFG_MSI) += irq-ls-scfg-msi.o >> obj-$(CONFIG_EZNPS_GIC) += irq-eznps.o >> +obj-$(CONFIG_SOC_NUC970) += irq-nuc900.o >> diff --git a/drivers/irqchip/irq-nuc900.c b/drivers/irqchip/irq-nuc900.c >> new file mode 100644 >> index 0000000..c4b2e39 >> --- /dev/null >> +++ b/drivers/irqchip/irq-nuc900.c >> @@ -0,0 +1,150 @@ >> +/* >> + * Copyright 2016 Wan Zongshun >> + * >> + * The code contained herein is licensed under the GNU General Public >> + * License. You may obtain a copy of the GNU General Public License >> + * Version 2 or later at the following locations: >> + * >> + * http://www.opensource.org/licenses/gpl-license.html >> + * http://www.gnu.org/copyleft/gpl.html >> + */ >> + >> +#include > > Why do you include module.h when I don't see anything modular in > this driver? Okay, I can delete it. > > Paul. > -- > >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> + > > [...] > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >