From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758424AbcGKKdF (ORCPT ); Mon, 11 Jul 2016 06:33:05 -0400 Received: from foss.arm.com ([217.140.101.70]:51973 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758406AbcGKKdC (ORCPT ); Mon, 11 Jul 2016 06:33:02 -0400 Subject: Re: [PATCH] iommu: arm-smmu: use devm_request_irq and devm_free_irq To: Peng Fan , will.deacon@arm.com References: <1467625102-9755-1-git-send-email-van.freenix@gmail.com> Cc: linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org From: Robin Murphy Message-ID: <578375D7.7090609@arm.com> Date: Mon, 11 Jul 2016 11:32:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1467625102-9755-1-git-send-email-van.freenix@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/16 10:38, Peng Fan wrote: > Use devm_request_irq to simplify error handling path, > when probe smmu device. > > Also devm_{request|free}_irq when init or destroy domain context. > > Signed-off-by: Peng Fan > Cc: Will Deacon > Cc: Robin Murphy > --- [...] > @@ -2050,7 +2046,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev) > dev_err(dev, "removing device with active domains!\n"); > > for (i = 0; i < smmu->num_global_irqs; ++i) > - free_irq(smmu->irqs[i], smmu); > + devm_free_irq(smmu->dev, smmu->irqs[i], smmu); There shouldn't be any need for this at all, since the very next thing called after drv->remove() is devres_release_all(). Robin. > > /* Turn the thing off */ > writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0); >