From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932685AbcGKRBB (ORCPT ); Mon, 11 Jul 2016 13:01:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932587AbcGKRA6 (ORCPT ); Mon, 11 Jul 2016 13:00:58 -0400 Message-ID: <5783D0C3.20804@redhat.com> Date: Mon, 11 Jul 2016 13:00:51 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Coelho, Luciano" , "linux-kernel@vger.kernel.org" CC: linuxwifi , "Berg, Johannes" , "kvalo@codeaurora.org" , "Ivgi, Chaya Rachel" , "netdev@vger.kernel.org" , "Sharon, Sara" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Subject: Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded References: <1468250301-10357-1-git-send-email-prarit@redhat.com> <1468253261.25088.126.camel@intel.com> In-Reply-To: <1468253261.25088.126.camel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 11 Jul 2016 17:00:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2016 12:07 PM, Coelho, Luciano wrote: > On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: >> Didn't get any feedback or review comments on this patch. Resending >> ... >> >> P. > > Sorry, this got flooded down my inbox. NP, Luciano -- My worry was that it hadn't been seen or didn't make it out to the list. I'm being a bit impatient too ;) P. > > >> ---8<--- >> >> The iwlwifi driver implements a thermal zone and hwmon device, but >> returns -EIO on temperature reads if the firmware isn't loaded. This >> results in the error >> >> iwlwifi-virtual-0 >> Adapter: Virtual device >> ERROR: Can't get value of subfeature temp1_input: I/O error >> temp1: N/A >> >> being output when using sensors from the lm-sensors package. Since >> the temperature cannot be read unless the ucode is loaded there is no >> reason to add the interface only to have it return an error 100% of >> the time. >> >> This patch moves the firmware check to >> iwl_mvm_thermal_zone_register() and >> stops the thermal zone from being created if the ucode hasn't been >> loaded. >> >> Signed-off-by: Prarit Bhargava >> Cc: Johannes Berg >> Cc: Emmanuel Grumbach >> Cc: Luca Coelho >> Cc: Intel Linux Wireless >> Cc: Kalle Valo >> Cc: Chaya Rachel Ivgi >> Cc: Sara Sharon >> Cc: linux-wireless@vger.kernel.org >> Cc: netdev@vger.kernel.org >> --- > > I have now sent it for review on our internal tree. > > -- > Luca. >