From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752100AbcGKTqy (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jul 2016 15:46:54 -0400
Received: from out1134-243.mail.aliyun.com ([42.120.134.243]:46442 "EHLO
	out1134-243.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750835AbcGKTqx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jul 2016 15:46:53 -0400
X-Greylist: delayed 316 seconds by postgrey-1.27 at vger.kernel.org; Mon, 11 Jul 2016 15:46:52 EDT
X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07462393|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03311;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=12;RT=12;SR=0;TI=SMTPD_----50GLNyZ_1468266083;
Message-ID: <5783F7DE.9020203@emindsoft.com.cn>
Date: Tue, 12 Jul 2016 03:47:42 +0800
From: Chen Gang <chengang@emindsoft.com.cn>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Minchan Kim <minchan@kernel.org>
CC: akpm@linux-foundation.org, vbabka@suse.cz, mgorman@techsingularity.net,
        mhocko@suse.com, gi-oh.kim@profitbricks.com, iamjoonsoo.kim@lge.com,
        hillf.zj@alibaba-inc.com, rientjes@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH] mm: migrate: Use bool instead of int for the return value
 of PageMovable
References: <1468079704-5477-1-git-send-email-chengang@emindsoft.com.cn> <20160711002605.GD31817@bbox>
In-Reply-To: <20160711002605.GD31817@bbox>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/11/16 08:26, Minchan Kim wrote:
> On Sat, Jul 09, 2016 at 11:55:04PM +0800, chengang@emindsoft.com.cn wrote:
>> From: Chen Gang <chengang@emindsoft.com.cn>
>>
>> For pure bool function's return value, bool is a little better more or
>> less than int.
>>
>> And return boolean result directly, since 'if' statement is also for
>> boolean checking, and return boolean result, too.
> 
> I just wanted to consistent with other PageXXX flags functions, PageAnon,
> PageMappingFlags which returns int rather than bool. Although I agree bool
> is natural, I want to be consistent with others rather than breaking at
> the moment.
> 
> Maybe if you feel it's really helpful, you might be able to handle all
> of places I mentioned for better readability and keeping consistency.

OK, I guess, we can send another patch for include/linux/page-flags.h
for PageXXX.

> But I doubt it's worth.
> 

In our case, the 2 output size are same, but under x86_64, the insns are
different. After uses bool, it uses push/pop instead of branch, for me,
it should be a little better for catching.

The orig:

  0000000000001290 <PageMovable>:
      1290:       48 8b 47 08             mov    0x8(%rdi),%rax
      1294:       83 e0 03                and    $0x3,%eax
      1297:       48 83 f8 02             cmp    $0x2,%rax
      129b:       74 03                   je     12a0 <__SetPageMovable+0x12a0>
      129d:       31 c0                   xor    %eax,%eax
      129f:       c3                      retq
      12a0:       55                      push   %rbp
      12a1:       48 89 e5                mov    %rsp,%rbp
      12a4:       e8 00 00 00 00          callq  12a9 <__SetPageMovable+0x12a9>
      12a9:       48 85 c0                test   %rax,%rax
      12ac:       74 17                   je     12c5 <__SetPageMovable+0x12c5>
      12ae:       48 8b 50 68             mov    0x68(%rax),%rdx
      12b2:       48 85 d2                test   %rdx,%rdx
      12b5:       74 0e                   je     12c5 <__SetPageMovable+0x12c5>
      12b7:       48 83 7a 68 00          cmpq   $0x0,0x68(%rdx)
      12bc:       b8 01 00 00 00          mov    $0x1,%eax
      12c1:       74 02                   je     12c5 <__SetPageMovable+0x12c5>
      12c3:       5d                      pop    %rbp
      12c4:       c3                      retq
      12c5:       31 c0                   xor    %eax,%eax
      12c7:       5d                      pop    %rbp
      12c8:       c3                      retq
      12c9:       0f 1f 80 00 00 00 00    nopl   0x0(%rax)

The new:

  0000000000001290 <PageMovable>:
      1290:       48 8b 47 08             mov    0x8(%rdi),%rax
      1294:       55                      push   %rbp
      1295:       48 89 e5                mov    %rsp,%rbp
      1298:       53                      push   %rbx
      1299:       31 db                   xor    %ebx,%ebx
      129b:       83 e0 03                and    $0x3,%eax
      129e:       48 83 f8 02             cmp    $0x2,%rax
      12a2:       74 05                   je     12a9 <__SetPageMovable+0x12a9>
      12a4:       89 d8                   mov    %ebx,%eax
      12a6:       5b                      pop    %rbx
      12a7:       5d                      pop    %rbp
      12a8:       c3                      retq
      12a9:       e8 00 00 00 00          callq  12ae <__SetPageMovable+0x12ae>
      12ae:       48 85 c0                test   %rax,%rax
      12b1:       74 f1                   je     12a4 <__SetPageMovable+0x12a4>
      12b3:       48 8b 40 68             mov    0x68(%rax),%rax
      12b7:       48 85 c0                test   %rax,%rax
      12ba:       74 e8                   je     12a4 <__SetPageMovable+0x12a4>
      12bc:       48 83 78 68 00          cmpq   $0x0,0x68(%rax)
      12c1:       0f 95 c3                setne  %bl
      12c4:       89 d8                   mov    %ebx,%eax
      12c6:       5b                      pop    %rbx
      12c7:       5d                      pop    %rbp
      12c8:       c3                      retq
      12c9:       0f 1f 80 00 00 00 00    nopl   0x0(%rax)

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.