From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932808AbcGLEbD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 00:31:03 -0400
Received: from mr213139.mail.yeah.net ([223.252.213.139]:34640 "EHLO
	mr213139.mail.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750743AbcGLEbA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 00:31:00 -0400
Subject: Re: [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support
To: Arnd Bergmann <arnd@arndb.de>
References: <1468135649-19980-1-git-send-email-vw@iommu.org>
 <1468135649-19980-2-git-send-email-vw@iommu.org>
 <18260150.aRRy8ybKlm@wuerfel>
Cc: linux-arm-kernel@lists.infradead.org, Russell King <linux@armlinux.org.uk>,
        devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        robh@kernel.org, jason@lakedaemon.net, p.zabel@pengutronix.de,
        Wan Zongshun <mcuos.com@gmail.com>
From: Wan Zongshun <vw@iommu.org>
Message-ID: <57847278.8000408@iommu.org>
Date: Tue, 12 Jul 2016 12:30:48 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <18260150.aRRy8ybKlm@wuerfel>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZIVUJPSEtLS0tMQ0lLSklCT1dZCQ4XHghZQV
	koKz0kNT4uLyk6NyQyNSQzPjo*PilBS1VLQDYjJCI#KCQyNSQzPjo*PilBS1VLQCsvKSQiPigkMj
	UkMz46Pz4pQUtVS0A4NC41LykiJDg1QUtVS0ApPjwyNDUkOigyOkFLVUtAKyk0LTI1OD4kKDM6NT
	wzOjJBS1VLQD8iNTo2MjgkMiskNTQkMjUkMz46Pz4pQUtVS0A2LjcvMiQpOCsvJD8yPT0#KT41Ly
	QyNSQzPjo*PilBSVVLQDIrJEhLJDYyNS4vPiQ4NS8kSyROS0FLVUtAMiskSiQ2MjUuLz4kODUvJE
	skSktBS1VLQDIrJC80PzoiJDg1LyRLJEpLS0FLVUtAMiskTiQ2MjUuLz4kODUvJEskSktBS1VLQD
	IrJEokMzQuKSQ4NS8kSyRKS0tBS1VLQCguOTE#OC8kLzQ*OiIkODUvJEskSktLQUtVS0AoLjkxPj
	gvJE4kNjI1Li8#JDg1LyRLJEpLQUtVS0AoLjkxPjgvJEokMzQuKSQ4NS8kSyRKS0tBS1VLQCg5MS
	Q3PjUkT0skI0FLVUtLSktALz4jLyQ3PjUkSElLJEpJQ0tBS1VLS0pLQDg1LyQzLzY3JDc#NSRKS0
	skSjBBS1VLS0pLQCk#OD4yLT4pJDg1LyROJCNBS1VLS0pLQCM2OjI3PikkNS43N0FLVUtLSktAPz
	43Mi0#KSQ3PjUkS0FLVUtLSktANzo1PCQ4NUFLVUtLSktAPSskKT4kPSwkMzcxJEtDS0hLTUFWTF
	VOQCguOSQ#QUpVTk5ZBg++
X-HM-Sender-Digest: e1kSHx4VD1lBWUc6Mwg6Aww4UTopMjI3LQ0NAk0iHTcaC0hVSlVKT01D
	SUJMQ09CT0pPVTMWGhIXVQ0MOxIUFhYOVRQJHEVZV1kMHhlZQR0aFwgeV1kIAVlBSU1LQzdXWRIL
	WUFZSUpLVUpIVUJMVUpNQ1kG
X-HM-Tid: 0a55dd5f29b27d8ba332c1c1d72
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016年07月12日 00:04, Arnd Bergmann wrote:
> On Sunday, July 10, 2016 3:27:21 PM CEST Wan Zongshun wrote:
>> +ifeq ($(CONFIG_SOC_NUC970),)
>>   obj-y                          := irq.o time.o mfp.o gpio.o clock.o
>>   obj-y                          += clksel.o dev.o cpu.o
>> +endif
>>   # W90X900 CPU support files
>
> When mfp.o is disabled like this, I get a link error in two drivers
> using the exported interface:
>
> ERROR: "mfp_set_groupg" [drivers/spi/spi-nuc900.ko] undefined!
> ERROR: "mfp_set_groupi" [drivers/input/keyboard/w90p910_keypad.ko] undefined!

Why remove mfp modules? this multifunction pin driver should be used for 
those two drivers, if no mfp_set_groupX, I don't think driver can work.

Now mfp has standard driver subsystem?

>
> Any idea for a better migration strategy?
>
> 	Arnd
>
>