From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbcGLXSd (ORCPT ); Tue, 12 Jul 2016 19:18:33 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:49677 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750787AbcGLXSW (ORCPT ); Tue, 12 Jul 2016 19:18:22 -0400 Subject: Re: [PATCH] loop: Make user notify for adding loop device failed To: Minfei Huang , , , , , References: <1465265115-12479-1-git-send-email-mnghuan@gmail.com> CC: From: Jens Axboe Message-ID: <57857A9F.8080700@fb.com> Date: Tue, 12 Jul 2016 16:17:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465265115-12479-1-git-send-email-mnghuan@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:200::c:7bc2] X-ClientProxiedBy: BLUPR11CA0028.namprd11.prod.outlook.com (10.141.240.38) To BLUPR15MB0450.namprd15.prod.outlook.com (10.163.214.16) X-MS-Office365-Filtering-Correlation-Id: 8e95aa86-e94c-4176-1ad6-08d3aaaac22b X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0450;2:sUtd87SdgWWm7bXQVn6wFzsnLrMgsndnTI1ZYJdKonEGJ6O0L5C33h2fIsizb/ZDMJf53w3r1lJELnYThHbwambES5TC6g4ZwgSBoP+bJnvg3uO0LtpnhOdel5mSHpcN2SSrQ2nBQayM7ARjhXXyTSEJE92bOXq5XKCq/b5DApcnTS0SK0+j5svtbvRLIyzY;3:Sf+7gWGPvsUCQX0s/DTVQU44Jp8jFj+O+ewBRKnhwPG1GhxVRsM7PPxwN8RIonxYS+lo9ALTrxAwNpZzvK5xk/+dgAg5nT0FsxiFUw0e23nKfICfcq9UHrAmmItQJ0ZX X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR15MB0450; X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0450;25:vnO8OO4ZqFliFreBJJD5e62o69OFioQp7nguz8cAr3rq0ylzN+tcR0LjTEyY/IUZWOLFEjrjXH0YqakQHH/lwM9Z5CvVWPHA0r1Vg8Xen6Px+SjWAyyUJ3aJoSlPIznPcFXy8cEOIlwf3HrbkNRIt043VwhNULVyGcQckupiZ3Ua8R04xsUaC+q+RmgkEAv2zzas1JQX2jAEOMgFWkhA/iYwPtZ5pG+GI++PJLb5Gj8ijk89kTxcBPIvpznsE+/6FL/5Xq+0SlsP5fuLWmR8hofLaPrJ2eQ+0Fo+OGw02BtdxdvEwTCMJSjScwst0rDV/tQBjyD1yGnKXZfjzGkZjy/y/8nKEGSqVL5Ap5xZokBid0y86A7UUU6edouU3iOG6yFyYp4kgtY8LBkBWZApXy6vDC6a1cmsdDoLAEN6ErlphpVOAu1F+5wRpke7NfaBOSGHjhCWnNOC/s379qI1/hBWypRAUuuWjJWZY4zGyu8HmC8RCyzHaHnI89fU2pVo4oKk9cZNYLkHwKFiHVTMjqm52J/ZElfF270OoIEOb2qd25wwofqDUlHktJOqV7rbBK74wrtIxy1Vqmps1QI0j1qprWAcDwln43AviIC63jAkRYAJ4mo/TrAo5JfE7O/sGYQmv82L63h6lfrDqfFj7xVnopqbe7wS4DBaTYX4p1++jOHFQiVGlXRaFEM2kaLdmV+LiksU543N8wGz4yvhC1T32W9BAVII1T50s/kQJq0bRlHfmxPVvdSv1qNPabBX X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0450;31:vccX77QzbgB8tbEKoZz55evHQcIycJfxvK28BsRLOpUfUhYcvuRmuf71yU/2CdHoDfKk4YyrPBZACd677TSCAMaERgMYBDpfCCnv9AsrBw3e8GAw/MV/saRpeMy61nq761GImmAM76/wbPlPdKmsWEw9EJ2ucPHkD9cBSjChetBHZkDaLlPpFLp1x3kesoeQtsrfP/9B5/dggaE1O3xXfA==;20:fO54bxuTt8JrZEkMdmogGzQ0V0CNZDxz0r7TR+sGLYJKYJlfgpYorVmoZfLiPXLX+Qk4XvO6dLkn/itI0yC1Ssfix07tgHvFPo3ux95zZ+RuY2O5HnJFDntCm5n+8ack4Y+5dXzCBllROmq1R/hEyg4VuHrimD2+KtjpBFOqw0s=;4:8lQ+z0+OlfawRIRMkcetXEa4WNbj+uEJD3ov/grw45gThFBirW4JzfDNkj82LWhsjZCHTVbw7K/2dpxoXZtUfbNaU3G0cpOmZQbCUepVLoR6PJVdSmFc2jFndRkGyuyELMafWtpFjFxTXjxpM3NcGQndhOziwkyY6TN8BLyFloYuwqIferCa4G1ZzSSwrg6v3HpRB7HrJo8yuvzTxsitSVWWPsZuRIsgeXNg//Gq7EuiRALHhdgD6QkUZBoKbW3dyU903rDOf9B3a7NkPNoctim2UmtfFzufVemT+v/aAYn5rrdpbVkf+5KEoST4yUp8P87Kk8eD95QwbH0hPVSTcIbDgoFjI0bwXiVLu9hB8yI22nol4Ja4RDPSrBBYY800 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BLUPR15MB0450;BCL:0;PCL:0;RULEID:;SRVR:BLUPR15MB0450; X-Forefront-PRVS: 0001227049 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(377454003)(101416001)(76176999)(54356999)(8676002)(230700001)(50986999)(47776003)(87266999)(65816999)(1706002)(189998001)(97736004)(65806001)(65956001)(5001770100001)(105586002)(6116002)(558084003)(586003)(36756003)(81166006)(81156014)(64126003)(92566002)(68736007)(50466002)(305945005)(7736002)(4326007)(7846002)(2906002)(42186005)(99136001)(33656002)(83506001)(59896002)(80316001)(23746002)(77096005)(106356001)(86362001)(4001350100001)(2950100001)(2201001)(3826002)(2101003);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR15MB0450;H:[IPv6:2620:10d:c082:1055:7572:8bf9:6a54:8e40];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR15MB0450;23:xmfU5sIK0amOUDhDkIZLlr+3uLOGOCZZKe5MI?= =?Windows-1252?Q?8BNamMoOnxeeOv0oPIRWZ31UZ06K3IQHOahFuG3kj0bFc+Z/EhOxtEDA?= =?Windows-1252?Q?3J1bY386zfkvR8LpOmkta+Z/aLIW0fOre9aocEZcXmnzy/l9lCD4yjM5?= =?Windows-1252?Q?0QD9DanZ8rQPxI5i4NzG3RY34euv0zhbiUCkMGT02nfFci3NBGvAJk+B?= =?Windows-1252?Q?GhAKl9flTnZzS4coTflZa2TgnfYSgfeXS4e7WdVkthurStI66iHML/XA?= =?Windows-1252?Q?qJEolpFKbj9f8QuXSaOshNk7EyrB4agNeXtqhtW36I2ZSV2HwoC0dDw4?= =?Windows-1252?Q?FQ/+/ZiywlZp3n0QcrRfjTY65uNu26DtSB0+a0aJUzUz27Q3jp9Q8jBf?= =?Windows-1252?Q?RHGpyiLEMexGp5XHP1TGftEA8XrVwp1mH1P2tfld+wg3Uf8y7bY98rlA?= =?Windows-1252?Q?3meToJRle6XxKcdPmpBjRlC8dt2BT13jZggQF3/DuYjROUB55SLgUpny?= =?Windows-1252?Q?pXE88nH2XwSEv2nfYhMjrQ92w6wIMdLe1DG2APQ1xJb7Pi1FgCpchRxg?= =?Windows-1252?Q?Q6/cJKqqJYDjiCoQ48iX4HGtQw+NLmjkzc2bsNdWHYHtWtznYbo4mVEr?= =?Windows-1252?Q?nPZiuz32MhYtZ58bn2sCPpALMNXRWSV0zKMVnnom+kbFAl4h39gG8sfy?= =?Windows-1252?Q?qcNFfeOChWVp0w6fGaoEapZVcPdaAGl7+z5HGN+PAgeBHH64cd23H48h?= =?Windows-1252?Q?Zduoh7fm+jI/VyWyy1HBe67gvq98+vrs5o94UxuAAXcsEUhVMEzB/3Sk?= =?Windows-1252?Q?gy7sL27z7GJWM50vbhRH+dXNHugMkqcvfH9rEqiaUuxZPQ5inp76c1Bu?= =?Windows-1252?Q?T1aEHnL7aKJhPfLTf8MTyKfu7SRL7i3lWFQUfa5wHOBksQXkZfoLYki6?= =?Windows-1252?Q?KVsdphb5o0ItCoO+BEkGil8VzSru5tKeFR+owT687xzXA2xfKteaaJxR?= =?Windows-1252?Q?FWZaGrfGq+O/wYuZ7wktWNLI+I0sMxoqTlrwQhM1LefA9OWK+kM3Wtas?= =?Windows-1252?Q?ljptm4NxA7+AGEx+A9pRLFFzynRwGD8lqdDkUek4iHi5go3ke8mc30dG?= =?Windows-1252?Q?YqwvY0uqPOYQY0GGb3P23JujTPLwn/H7Vu/F7aucS6fbh+SdhLK5WD7M?= =?Windows-1252?Q?6Zjdr87vXBRICR7pINotRQoz1CWUlIPfCrdHGNK3OSAPm+cYeUW+biOB?= =?Windows-1252?Q?m45cCWmUYFN90IWRQO1bKmRzgqyaR1XDkVXHqRYUSmsGi2OvNSUd2n22?= =?Windows-1252?Q?0SlxnfqF5Ux625P2qXZGJNkyRv2uGCWmxIWk803zZcpkYvO+3oZkuhu+?= =?Windows-1252?Q?jYaGA1njbNLl1HJPiiuxl4U8ZV+x9YJ2TKF3xoBkr88NLMXKQj6xic?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0450;6:dcIMzBfug7tlJFs41lu2aJjgbmnhAjAGogluIW4VwiM/8NV8swyYPMcRPhAVymUSZfXe7ebjUrPFEugCM83l6DDXL5ZHDUaQUpjcb2HSEwlAna3hReE4GDWaxhycLHWQc9AaxN2Omsj5szUaMG4V3vNLwSzoYGI5EgmooS3bbZx1yNy6QWFeSxr6/AfMTWkKJRHLAiG/dsT8GrZp46AdR52sZJgZR6uZ2Y6tNq0MpYNwmFgqtbpmDj+kUJoUq/D0ZuVPXCFnKsEVcPmLGBb85dPvrlkG8WN40YAALE/k4To=;5:uC0n17T9sy81Yjjwd7MYCHdgZXo/yxSLE6ja/c4BchF2la24WaqqEZinJ9FuksjwQ6rS4oIJmCw01PUdas0ksMBVNR2qpXxBQusKCW9DRUgoh/TWIHqKGQJlBT0PaANbJRGhcqywpchQuXYm7dlznA==;24:23rCXw80c0vflarh7IHc5ojMYghCsBDUVLz92qv70PLaIFsGpKB3ummcj9mncOtq04Jz19NY3w26Weoc0zEsf1BbCBpGRs/MF/Kj2D/LDGs=;7:oSyQSsLdM4x/0PFRo8YKR5Qd7P0D3wWRrk5sQrsvKkBWJrNfVPvrw12nvi1thnMPOIhdLlbe+1z2fNjIbVg9BDB0cg5wiDYWX7TVKH2nEFgugmBIHAXi3CHJ39yjdvVgsF/LVT2j1DAi7acMX24PByG7LT+/GbqacoZU8CZoT+eK5xktZsoNyi2ozmd7OL0mYRDhY1khOsa52m471LQh2b3PfYUL7zPzKvMJcZXwYTCEQNSSqFbrjb3xY+lHWRqF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0450;20:S6sqnwuOq9ieRECWRtg3/mnhUq5GOYGC84KrWKGQTJE4IIQLRDgs3QaDYtw834GdY4qVkWfw/EmSCyGYfrGXhJ5eEujzcZPymsmoiGm2Cx8CYFoLsHnVGN/8GSXuGFzCDevaegbbWlsUkpKexc1Px8eknBXDgzHaKaHIyQ3gdcA= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 23:17:55.8189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR15MB0450 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-12_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 07:05 PM, Minfei Huang wrote: > There is no error number returned if loop driver fails in function > alloc_disk to add new loop device. Add a correct error number to make > user notify in this case. Sorry about the delay, vacation got in the way. Added for 4.8, thanks. -- Jens Axboe