From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752843AbcGMJ3u (ORCPT ); Wed, 13 Jul 2016 05:29:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46431 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751425AbcGMJ3q (ORCPT ); Wed, 13 Jul 2016 05:29:46 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: ravi.bangoria@linux.vnet.ibm.com Subject: Re: [PATCH v3 3/4] perf annotate: add powerpc support To: Michael Ellerman , Arnaldo Carvalho de Melo References: <1467267262-4589-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1467267262-4589-4-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1467267714.7296.6.camel@ellerman.id.au> <57762D2A.9040103@linux.vnet.ibm.com> <87vb0j84fb.fsf@@concordia.ellerman.id.au> <577F31D9.4050808@linux.vnet.ibm.com> <87zipsmsyd.fsf@@concordia.ellerman.id.au> <5784543A.9030801@linux.vnet.ibm.com> <20160712023937.GC3387@kernel.org> <87eg6ym1gq.fsf@@concordia.ellerman.id.au> Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, anton@ozlabs.org, ananth@in.ibm.com, dja@axtens.net, naveen.n.rao@linux.vnet.ibm.com, David.Laight@ACULAB.COM, Ravi Bangoria From: Ravi Bangoria Date: Wed, 13 Jul 2016 14:59:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87eg6ym1gq.fsf@@concordia.ellerman.id.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071309-0016-0000-0000-0000042B0C91 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071309-0017-0000-0000-0000310F7934 Message-Id: <578609F3.5090707@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-13_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607130108 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 13 July 2016 01:09 PM, Michael Ellerman wrote: > Arnaldo Carvalho de Melo writes: > >> Em Tue, Jul 12, 2016 at 07:51:46AM +0530, Ravi Bangoria escreveu: >>> Hi Arnaldo, >>> >>> On Friday 08 July 2016 02:01 PM, Michael Ellerman wrote: >>>> Ravi Bangoria writes: >>>> >>>>> On Wednesday 06 July 2016 03:38 PM, Michael Ellerman wrote: >>>>> >>>>> I've sent v4 which enables annotate for bctr' instructions. >>>>> >>>>> for 'bctr', it will show down arrow(indicate jump) and 'bctrl' will show >>>>> right arrow(indicate call). But no navigation options will be provided. >>>>> By pressing Enter key on that, message will be shown that like >>>>> "Invalid target" >>>> Great thanks. >>> I've sent v4 series. Please review it. >> If somebody else could do it and provide acks/reviewed by, that would >> help, >> >> Michael, can I get your comments as such? > It looks OK to me. But I don't know the code really, and I haven't had > time to test it personally. > > Ravi, have you tested on a big endian machine? Yes Michael, I've tested annotate on BE and LE both. -Ravi > > cheers >