From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751058AbcGMLEe (ORCPT ); Wed, 13 Jul 2016 07:04:34 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:23368 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbcGMLEY (ORCPT ); Wed, 13 Jul 2016 07:04:24 -0400 X-AuditID: cbfec7f5-f792a6d000001302-76-5786200a00c8 Subject: Re: [PATCH v6 17/46] infiniband: dma-mapping: Use unsigned long for dma_attrs To: Bart Van Assche , Andrew Morton References: <1468399167-28083-1-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-5-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-6-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-7-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-8-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-9-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-10-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-11-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-12-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-13-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-14-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-15-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-16-git-send-email-k.kozlowski@samsung.com> <1468399300-5399-17-git-send-email-k.kozlowski@samsung.com> <3ed39f35-f19e-1593-72a5-0d7240fa7a4e@sandisk.com> <57861C2A.2090206@samsung.com> <6f3511c2-0795-ce1a-44c4-426feaf97c03@sandisk.com> Cc: linux-kernel@vger.kernel.org, hch@infradead.org, Bartlomiej Zolnierkiewicz , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57862008.1080502@samsung.com> Date: Wed, 13 Jul 2016 13:03:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <6f3511c2-0795-ce1a-44c4-426feaf97c03@sandisk.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xa7pcCm3hBk93SFrMWb+GzWLjjPWs Fgd/tjFavDz/gdVi4+aJjBanJyxisnj9wtDi8q45bBbPDvWyWDSv38DiwOWxc9Zddo/NK7Q8 Fu95yeRxYsZvFo/3+66yefRtWcXoMW3NeSaPz5vkAjiiuGxSUnMyy1KL9O0SuDIOzDzLWLCY p2LGx73sDYx/OLsYOTkkBEwk2g+dYoKwxSQu3FvP1sXIxSEksJRRYk7LdmYI5xmjRPvPe6wg VcICERIvp8xgBLFFBGIlOm4fg+r4zC6xfeNDJhCHWeAvo8TcTdfYQKrYBIwlNi9fAmbzCmhJ fF3bCtTNwcEioCqxY6oFSFgUaOis7T+YIEoEJX5MvscCYnMK2Eu07fkOVs4soCdx/6IWSJhZ QF5i85q3zBMYBWYh6ZiFUDULSdUCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCHR8XUH 49JjVocYBTgYlXh4Vwi2hguxJpYVV+YeYpTgYFYS4Y2QawsX4k1JrKxKLcqPLyrNSS0+xCjN waIkzjtz1/sQIYH0xJLU7NTUgtQimCwTB6dUA6Oi/NyjDC1v9K5+z/B8dvpwrcfe23xXY5fu 3xE6lfnm4+5pgdvWHF5zIGGqEOtpS4YSq5MsLx+eU+P4NGlix1b/LyyqOw3Nb95ettiti61C 4Razq7DYRCbhgJD1W9eUdwUK7Hm9s6cxQ+vb4Q/7FP+VGk4UN0lKEf4UdGYbq7/fq1vJqzPD +nOVWIozEg21mIuKEwE9EeQiigIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2016 12:56 PM, Bart Van Assche wrote: > On 07/13/2016 05:47 PM, Krzysztof Kozlowski wrote: >> On 07/13/2016 12:37 PM, Bart Van Assche wrote: >>> On 07/13/2016 03:41 PM, Krzysztof Kozlowski wrote: >>>> Split out subsystem specific changes for easier reviews. This will be >>>> squashed with main commit. >>> >>> Apparently my comment has been ignored >>> (http://thread.gmane.org/gmane.linux.ports.m68k/8746/focus=37703). Are >>> you aware that you are expected to reply to feedback on patches? >> >> Of course your comment was not ignored. I am sorry that you have such >> impression. However I thought you are referring only to local variable >> which name I changed. >> >> Do you want me to rename also the argument in the ib_dma_map_sg_attrs() >> and ib_dma_unmap_sg_attrs() functions? > > Hello Krzysztof, > > Sorry if I was not clear enough in the comment I had posted in reply to > the previous version of this patch series. In my comment I wanted indeed > to refer to the name of the ib_dma_map_sg_attrs() / > ib_dma_unmap_sg_attrs() function argument. An argument with the name > "attrs" namely does not explain what kind of attributes that argument > refers to ... I can rename it, no problem. It looks to me a little bit redundant information as these are just wrappers over dma_{map,unmap}_sg_attrs() where the attrs are also used. Everything there refers to the mapping of scatter gather list. Anyway, renaming won't harm neither so let me send a follow up only for this patch. Thanks for feedback! Krzysztof