From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752351AbcGMMxt (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 08:53:49 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:9940 "EHLO SMTP02.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751044AbcGMMxk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 08:53:40 -0400
X-IronPort-AV: E=Sophos;i="5.28,357,1464652800"; 
   d="scan'208";a="372924142"
Subject: Re: [Xen-devel] [PATCH 2/2] Allow kdump with
 crash_kexec_post_notifiers
To: Petr Tesarik <ptesarik@suse.com>, Juergen Gross <jgross@suse.com>,
        "Josh Triplett" <josh@joshtriplett.org>,
        Ingo Molnar <mingo@redhat.com>, "Thomas Gleixner" <tglx@linutronix.de>,
        Eric Biederman <ebiederm@xmission.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Dave Young <dyoung@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Vrabel <david.vrabel@citrix.com>
References: <20160713121950.14969.78606.stgit@hananiah.suse.cz>
 <20160713122000.14969.99963.stgit@hananiah.suse.cz>
CC: "moderated list:XEN HYPERVISOR INTERFACE" 
	<xen-devel@lists.xenproject.org>,
        "maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel.org>,
        "open list:KEXEC" <kexec@lists.infradead.org>,
        "open list" <linux-kernel@vger.kernel.org>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <578639AE.10500@citrix.com>
Date: Wed, 13 Jul 2016 13:53:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160713122000.14969.99963.stgit@hananiah.suse.cz>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13/07/16 13:20, Petr Tesarik wrote:
> If a crash kernel is loaded, do not crash the running domain. This is
> needed if the kernel is loaded with crash_kexec_post_notifiers, because
> panic notifiers are run before __crash_kexec() in that case, and this
> Xen hook prevents its being called later.

Prioritising the in-kernel kexec image over the hypervisor one seems
sensible behaviour to me.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

David