From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932173AbcGMQOp (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 12:14:45 -0400
Received: from mx2.suse.de ([195.135.220.15]:56471 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752100AbcGMQOd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 12:14:33 -0400
Subject: Re: [PATCH] arm64: Add config to limit user space to 47bits
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <1468424567-15925-1-git-send-email-agraf@suse.de>
 <CAKv+Gu_QH=sZi--FVqHebd1P+6UMzEqWQQ1u3Y170B7cND8Kgw@mail.gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        mbrugger@suse.com
From: Alexander Graf <agraf@suse.de>
Message-ID: <578668D3.6010406@suse.de>
Date: Wed, 13 Jul 2016 18:14:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu_QH=sZi--FVqHebd1P+6UMzEqWQQ1u3Y170B7cND8Kgw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/13/2016 05:59 PM, Ard Biesheuvel wrote:
> On 13 July 2016 at 17:42, Alexander Graf <agraf@suse.de> wrote:
>> Some user space applications are known to break with 48 bits virtual
> known by whom? At least I wasn't aware of it, so could you please
> share some examples?

Sure! Known to me so far are:

   * mozjs17
   * mozjs24
   * mozjs38
   * js-1.8.5
   * java-1.7 (older JITs, fixed in newer ones)

I'm not sure if there are more, but the fact that I've run into this 
problem more than once doesn't make me incredibly happy :).

>
>> address space. As interim step until the world is healed and everyone
>> embraces correct code, this patch allows to only expose 47 bits of
>> virtual address space to user space.
>>
> Is this a code generation/toolchain issue?

mozjs uses a single 64bit value to combine doubles, ints and pointers 
into a single variable. It is very smart and uses the upper 17 bits for 
metadata such as "which type of variable is this". Coincidentally those 
bits happen to overlap the "double is an infinite number" bits, so that 
you can also express a NaN with it. When using such a value, the upper 
17 bits get masked out.

That one was fixed upstream by force allocating the javascript heap 
starting at a fixed location which is below 47 bits.

js-1.8.5 has the same as above, but also uses pointers to .rodata as 
javascript pointers, so it doesn't only use the heap, it also uses 
pointers to the library itself, which gets mapped high up the address 
space. I don't have a solution for that one yet.

IcedTea for java-1.7 had a bug where it incorrectly caused an overflow 
when trying to calculating a relative adrp offset from <address high up> 
to <address really low>, so that the resulting pointer had the upper 
bits set as 1s. That one is long fixed upstream, we only ran into it 
because we used an ancient IcedTea snapshot.

My main concern however is with code that I do not know is broken today.


Alex