From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824AbcGNBPK (ORCPT ); Wed, 13 Jul 2016 21:15:10 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:32838 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbcGNBPE (ORCPT ); Wed, 13 Jul 2016 21:15:04 -0400 X-AuditID: cbfee68d-f79876d000001436-69-5786e795aa2a Message-id: <5786E795.6040504@samsung.com> Date: Thu, 14 Jul 2016 10:15:01 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Chris Zhong , dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de, yzq@rock-chips.com, groeck@chromium.org, myungjoo.ham@samsung.com, wulf@rock-chips.com, marcheu@chromium.org Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v5 PATCH 1/5] extcon: Add Type-C and DP support References: <1468336188-565-1-git-send-email-zyw@rock-chips.com> <1468336188-565-2-git-send-email-zyw@rock-chips.com> <57859532.1010002@samsung.com> <57859BDA.7080309@rock-chips.com> <5785A1F3.1020703@samsung.com> <5785AD61.3070307@rock-chips.com> <5786E1B6.2000805@samsung.com> <5786E4E7.30505@rock-chips.com> In-reply-to: <5786E4E7.30505@rock-chips.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsWyRsSkUHfq87Zwg+U31S3OLjvIZnHq1TJm i/+PXrNaXN41h83i04P/zBbzDv1mtLjduILN4nPrPzaLVWuPM1vMXbeEzWL+gx3MDtwesxsu snhsXlLv8XfWfhaPvi2rGD22X5vH7PF5k1wAWxSXTUpqTmZZapG+XQJXxsnWC6wFR0UqXrxq YWxg3CHQxcjBISFgInHxsmcXIyeQKSZx4d56ti5GLg4hgRWMEgePnmeDSJhI3H27jxkiMYtR Yt3Fg4wgCSGBB4wSn1uyQWxeAS2JzrN72EFsFgFViVdbPoLZbEDx/S9usIEsExWIkOg+UQlR LijxY/I9FpCZIgKXGCWWPmxhB6lhFnCRmPKRG8QUFrCVOPquDGLTJGaJt3fVQGxOAR2J4/83 skFUq0tMmZILEmYWkJfYvOYt2JUSAl/ZJda+fQt1jYDEt8mHWCDelZXYdIAZ4itJiYMrbrBM YBSbheSgWQhTZyGZuoCReRWjaGpBckFxUnqRoV5xYm5xaV66XnJ+7iZGYHSe/vesdwfj7QPW hxgFOBiVeHgjetvChVgTy4orcw8xmgIdMZFZSjQ5H5gC8kriDY3NjCxMTUyNjcwtzZTEeRWl fgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYLwts4tZf82kz+lTDoptd5jc+OjKX7UZyWKJ vI1BZUd9NEycIguEKp8/E2EKs2rbKWVX8eTIZvPUROnglzqr+89tOd7/+V2ggMXfK+vL1i5q cVFtX2xZkzpvsZkZq/QJ3nssj67U2RzOcdT90THJPCb8qxMf39nr8hff/arde+vu2rf+jyee 2qHEUpyRaKjFXFScCADfv6xeyQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42I5/e+xoO7U523hBveuKVqcXXaQzeLUq2XM Fv8fvWa1uLxrDpvFpwf/mS3mHfrNaHG7cQWbxefWf2wWq9YeZ7aYu24Jm8X8BzuYHbg9Zjdc ZPHYvKTe4++s/SwefVtWMXpsvzaP2ePzJrkAtqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4 UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoPuUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqG BMH1GBmggYQ1jBknWy+wFhwVqXjxqoWxgXGHQBcjJ4eEgInE3bf7mCFsMYkL99azdTFycQgJ zGKUWHfxICNIQkjgAaPE55ZsEJtXQEui8+wedhCbRUBV4tWWj2A2G1B8/4sbQM0cHKICERLd JyohygUlfky+xwIyU0TgEqPE0oct7CA1zAIuElM+coOYwgK2EkfflUFsmsQs8fauGojNKaAj cfz/RjaIanWJKVNyQcLMAvISm9e8ZZ7ACHQiwoJZCFWzkFQtYGRexSiRWpBcUJyUnmuYl1qu V5yYW1yal66XnJ+7iRGcAp5J7WA8uMv9EKMAB6MSD+/XTW3hQqyJZcWVuYcYJTiYlUR4Nz0B CvGmJFZWpRblxxeV5qQWH2I0BQbARGYp0eR8YHrKK4k3NDYxM7I0Mje0MDI2VxLnffx/XZiQ QHpiSWp2ampBahFMHxMHp1QDI6dbfbHQxv3bW3ZJ/LR7ve+D9MPmKsMI1cTHEl3+56f9PZ/W wr1A6XnUl4n3iy/WrMg9cbbHaZ3xpu/tIhNzLh00+tUpbi9+9+X8wll2XgJcZTpzO1nYnvVc 7wzmPWTNMHPCrvir15emHdxVP/3prg/rNIKEt3uJaUXpsahdnFnzZtZvveY6VyWW4oxEQy3m ouJEAJ9mN/oXAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, [snip] >>>> Thanks, >>>> Chanwoo Choi >>> There are 4 modes for Type-C DP alt mode: >>> 1) USB host only : >>> >>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 1); >>> extcon_set_cable_state(edev, EXTCON_USB, 0); >>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 0); >>> >>> 2) USB device only >>> >>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 0); >>> extcon_set_cable_state(edev, EXTCON_USB, 1); >>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 0); >>> >>> 3) DP only >>> >>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 0); >>> extcon_set_cable_state(edev, EXTCON_USB, 0); >>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 1); >>> >>> 4) USB + DP >>> >>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 1); >>> extcon_set_cable_state(edev, EXTCON_USB, 0); >>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 1); >>> >>> >>> for 3rd mode: DP only, there is only EXTCON_DISP_DP is attached, the EXTCON_USB_HOST >>> and EXTCON_USB are detached, Can I set the property into these 2 detached cable? >>> or just call extcon_set_cable_state(edev, EXTCON_DISP_DP, EXTCON_PROP_TYPEC_POLARITY, 0 or 1); >> I'm thinking to solve this issue. In result, we can add one more type to specific connector. >> For EXTCON_DISP_DP, we can add the two type as following. And EXTCON_PROP_TYPEC_POLARITY property >> should be added to EXTCON_TYPE_USB. >> >> + [EXTCON_DISP_DP] = { >> + .type = EXTCON_TYPE_DISP | EXTCON_TYPE_USB, >> + .id = EXTCON_DISP_DP, >> + .name = "DP", >> + }, >> >> So, as you mentioned, EXTCON_DISP_DP can set the EXTCON_PROP_TYPEC_POLARITY property as following: >> - extcon_set_cable_state(edev, EXTCON_DISP_DP, EXTCON_PROP_TYPEC_POLARITY, 0 or 1); >> >> I'll again developing the extcon property. >> >> Thanks, >> Chanwoo Choi >> > Nice idea, But I am thinking about is it compatible with real DisplayPort without Type-C. > Maybe we should add a new cable: EXTCON_DISP_DP_ALT > > + [EXTCON_DISP_DP] = { > + .type = EXTCON_TYPE_DISP, > + .id = EXTCON_DISP_DP, > + .name = "DP", > + }, > > + [EXTCON_DISP_DP_ALT] = { > + .type = EXTCON_TYPE_DISP | EXTCON_TYPE_USB, > + .id = EXTCON_DISP_DP, > + .name = "DP ALT", > + }, EXTCON_DISP_DP_ALT means EXTCON_DISP_DP connector with EXTCON_PROP_TYPEC_POLARITY property. So, we can explain the DP alternative mode without EXTCON_DISP_DP_ALT. I'm wondering to add the new EXTCON_DISP_DP_ALT connector because alternative mode was defined as mode instead of new h/w connector type. Thanks, Chanwoo Choi