From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751211AbcGNCKr (ORCPT ); Wed, 13 Jul 2016 22:10:47 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:52043 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbcGNCKi (ORCPT ); Wed, 13 Jul 2016 22:10:38 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f79476d000001429-81-5786f49ca0d6 Content-transfer-encoding: 8BIT Message-id: <5786F49B.20107@samsung.com> Date: Thu, 14 Jul 2016 11:10:35 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Chris Zhong , dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de, yzq@rock-chips.com, groeck@chromium.org, myungjoo.ham@samsung.com, wulf@rock-chips.com, marcheu@chromium.org Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v5 PATCH 1/5] extcon: Add Type-C and DP support References: <1468336188-565-1-git-send-email-zyw@rock-chips.com> <1468336188-565-2-git-send-email-zyw@rock-chips.com> <57859532.1010002@samsung.com> <57859BDA.7080309@rock-chips.com> <5785A1F3.1020703@samsung.com> <5785AD61.3070307@rock-chips.com> <5786E1B6.2000805@samsung.com> <5786E4E7.30505@rock-chips.com> <5786E795.6040504@samsung.com> <5786F3FB.5010608@rock-chips.com> In-reply-to: <5786F3FB.5010608@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsWyRsSkUHfOl7Zwg6/rZCzOLjvIZnHq1TJm i/+PXrNaXN41h83i04P/zBbzDv1mtLjduILN4nPrPzaLVWuPM1vMXbeEzWL+gx3MDtwesxsu snhsXlLv8XfWfhaPvi2rGD22X5vH7PF5k1wAWxSXTUpqTmZZapG+XQJXxtcZv9kLHolX/Fq3 l7mBcYZwFyMnh4SAicSVpvdMELaYxIV769m6GLk4hARWMEpcbHrCClO0aucnRojEUkaJB9MW gHXwCghK/Jh8j6WLkYODWUBe4silbAhTXWLKlFyI8geMEnN3b4Eq15C4sv0bG4jNIqAq8X/y EzCbTUBLYv+LG2wgvaICERLdJypBekUELjFKLH3Ywg4x00ViykduEFNYwFbi6LsykE4hgavM EusvuYDYnAJ6EpN3roB65Su7ROdkPohNAhLfJh8CO1JCQFZi0wFmiBJJiYMrbrBMYBSbheSV WQivzEJ4ZQEj8ypG0dSC5ILipPQiY73ixNzi0rx0veT83E2MwNg8/e9Z/w7GuwesDzEKcDAq 8fCeWNIWLsSaWFZcmXuI0RTohonMUqLJ+cAEkFcSb2hsZmRhamJqbGRuaaYkzrtQ6mewkEB6 YklqdmpqQWpRfFFpTmrxIUYmDk6pBsYkvecrpv8uWJttuG3lxruLrvrtdn2y9LFhga3t7Vff LL/YO5RHczXe/sPHs2LfpFOVHv95103KtK9R+9kY97KL43hWNb8Z66R0jQlaR4y+ml1aduC6 xeLQdbX90/adOzTbu/Vtx5sXK1gmhXlv1Aht/OAtGGbgphMTl9v1XEPi2oOuCV0HfKcosRRn JBpqMRcVJwIAoPxWNcgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42I5/e+xgO6cL23hBk3XxCzOLjvIZnHq1TJm i/+PXrNaXN41h83i04P/zBbzDv1mtLjduILN4nPrPzaLVWuPM1vMXbeEzWL+gx3MDtwesxsu snhsXlLv8XfWfhaPvi2rGD22X5vH7PF5k1wAW1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8 qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0H1KCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1D guB6jAzQQMIaxoyvM36zFzwSr/i1bi9zA+MM4S5GTg4JAROJVTs/MULYYhIX7q1n62Lk4hAS WMoo8WDaAiaQBK+AoMSPyfdYuhg5OJgF5CWOXMqGMNUlpkzJhSh/wCgxd/cWqHINiSvbv7GB 2CwCqhL/Jz8Bs9kEtCT2v7jBBtIrKhAh0X2iEqRXROASo8TShy3sEDNdJKZ85AYxhQVsJY6+ KwPpFBK4yiyx/pILiM0poCcxeecKpgmMArOQ3DYL4bZZCLctYGRexSiRWpBcUJyUnmuYl1qu V5yYW1yal66XnJ+7iRGcAJ5J7WA8uMv9EKMAB6MSD+/XTW3hQqyJZcWVuYcYJTiYlUR4z30C CvGmJFZWpRblxxeV5qQWH2I0BXpuIrOUaHI+MDnllcQbGpuYGVkamRtaGBmbK4nzPv6/LkxI ID2xJDU7NbUgtQimj4mDU6qB8QRzqc9xVQG9FL2aBwJb0uc+K0tISv+94u6i7zt6rxy9WnPF 8uQzZS+9m0azkvnuWn/z0P8fcbim0qZdkcHfxYVRM9d4wYLvEjP3/ueULlXZwCr6P3Vj88Gc Ht1lmw5399czTblsduP7wx9iClomrz1Vr55zrf9uZj7LdEt5+fn6newT/5cvVmIpzkg01GIu Kk4EAAjBPBkWAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, On 2016년 07월 14일 11:07, Chris Zhong wrote: > Hi Chanwoo Choi > > On 07/14/2016 09:15 AM, Chanwoo Choi wrote: >> Hi Chris, >> >> [snip] >> >>>>>> Thanks, >>>>>> Chanwoo Choi >>>>> There are 4 modes for Type-C DP alt mode: >>>>> 1) USB host only : >>>>> >>>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 1); >>>>> extcon_set_cable_state(edev, EXTCON_USB, 0); >>>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 0); >>>>> >>>>> 2) USB device only >>>>> >>>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 0); >>>>> extcon_set_cable_state(edev, EXTCON_USB, 1); >>>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 0); >>>>> >>>>> 3) DP only >>>>> >>>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 0); >>>>> extcon_set_cable_state(edev, EXTCON_USB, 0); >>>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 1); >>>>> >>>>> 4) USB + DP >>>>> >>>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 1); >>>>> extcon_set_cable_state(edev, EXTCON_USB, 0); >>>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 1); >>>>> >>>>> >>>>> for 3rd mode: DP only, there is only EXTCON_DISP_DP is attached, the EXTCON_USB_HOST >>>>> and EXTCON_USB are detached, Can I set the property into these 2 detached cable? >>>>> or just call extcon_set_cable_state(edev, EXTCON_DISP_DP, EXTCON_PROP_TYPEC_POLARITY, 0 or 1); >>>> I'm thinking to solve this issue. In result, we can add one more type to specific connector. >>>> For EXTCON_DISP_DP, we can add the two type as following. And EXTCON_PROP_TYPEC_POLARITY property >>>> should be added to EXTCON_TYPE_USB. >>>> >>>> + [EXTCON_DISP_DP] = { >>>> + .type = EXTCON_TYPE_DISP | EXTCON_TYPE_USB, >>>> + .id = EXTCON_DISP_DP, >>>> + .name = "DP", >>>> + }, >>>> >>>> So, as you mentioned, EXTCON_DISP_DP can set the EXTCON_PROP_TYPEC_POLARITY property as following: >>>> - extcon_set_cable_state(edev, EXTCON_DISP_DP, EXTCON_PROP_TYPEC_POLARITY, 0 or 1); >>>> >>>> I'll again developing the extcon property. >>>> >>>> Thanks, >>>> Chanwoo Choi >>>> >>> Nice idea, But I am thinking about is it compatible with real DisplayPort without Type-C. >>> Maybe we should add a new cable: EXTCON_DISP_DP_ALT >>> >>> + [EXTCON_DISP_DP] = { >>> + .type = EXTCON_TYPE_DISP, >>> + .id = EXTCON_DISP_DP, >>> + .name = "DP", >>> + }, >>> >>> + [EXTCON_DISP_DP_ALT] = { >>> + .type = EXTCON_TYPE_DISP | EXTCON_TYPE_USB, >>> + .id = EXTCON_DISP_DP, >>> + .name = "DP ALT", >>> + }, >> EXTCON_DISP_DP_ALT means EXTCON_DISP_DP connector with EXTCON_PROP_TYPEC_POLARITY property. >> So, we can explain the DP alternative mode without EXTCON_DISP_DP_ALT. >> >> I'm wondering to add the new EXTCON_DISP_DP_ALT connector >> because alternative mode was defined as mode instead of new h/w connector type. >> >> Thanks, >> Chanwoo Choi >> >> > Okay, so I think some comment for EXTCON_DISP_DP is necessary and enough. Okay. I'll do that Thanks, Chanwoo Choi