From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932186AbcGOH3J (ORCPT ); Fri, 15 Jul 2016 03:29:09 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:8298 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbcGOH3H (ORCPT ); Fri, 15 Jul 2016 03:29:07 -0400 X-AuditID: cbfec7f5-f792a6d000001302-6b-578890bedee9 Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg To: Shuah Khan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com, j.anaszewski@samsung.com, hans.verkuil@cisco.com References: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> Cc: javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <578890BA.8040101@samsung.com> Date: Fri, 15 Jul 2016 09:28:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsVy+t/xa7r7JnSEGxxp4bWY9bKdxWL+kXOs Fv1vFrJaLPm5i8ni3KuVjBa9V58zWrx5u4bJ4vULQ4v+x6+ZLTY9vsZqcXnXHDaLGef3MVks vX6RyWL1swqLCdPXsli07j3CbjH1ywcWB0GPNfPWMHpM+b2R1eNyXy+Tx8rlX9g8Nq3qZPPY vKTeY0v/XXaPvi2rGD0+b5IL4IzisklJzcksSy3St0vgyljb38BS0M5b8Xf1JfYGxl7uLkZO DgkBE4l5a++zQ9hiEhfurWfrYuTiEBJYyigxsaGLGcJ5xihx/P9KJpAqYYFwiYnnf7OAJEQE pjJJtOzvY+1i5ACqcpP4uysOJM4ssJBRYsa2FcwgDWwCxhKbly9hg1ghJ9HbPYkFpJ5XQEvi 0+wikDCLgKrEpLm7wEpEBSIkZm3/AbaLV0BQ4sfkeywgNqeAu8T7Jc1MIK3MAnoS9y9qgYSZ BeQlNq95yzyBUXAWko5ZCFWzkFQtYGRexSiaWppcUJyUnmukV5yYW1yal66XnJ+7iRESgV93 MC49ZnWIUYCDUYmHd8eh9nAh1sSy4srcQ4wSHMxKIrxuPR3hQrwpiZVVqUX58UWlOanFhxil OViUxHln7nofIiSQnliSmp2aWpBaBJNl4uCUamDkle9ed8bHc1a125X73wtnvZc7k93DfX9X +cyqH+c3T7a5qXxhT+fDRNU42a3vv3Kuf7H21sqNGvejTlw1PszpMf37iskzEx7LqM/cuNN4 QfO7dc6qhpMXev7d3cBUP39ty3eDWSV1+5IP67nyb2zRCVmoNXdvo1itlG5AwilrAZcP7/m5 pbOMlFiKMxINtZiLihMBxvDEIrwCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/14/2016 10:01 PM, Shuah Khan wrote: > Add add missing documentation for samsung,exynos4212-jpeg codec, > reorder entries to improve readability and make it easier to add > new entries. > > Signed-off-by: Shuah Khan > --- > Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > index 38941db..093614c 100644 > --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > @@ -3,9 +3,9 @@ Samsung S5P/EXYNOS SoC series JPEG codec > Required properties: > > - compatible : should be one of: > - "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg", > - "samsung,exynos3250-jpeg", "samsung,exynos5420-jpeg", > - "samsung,exynos5433-jpeg"; > + "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", > + "samsung,exynos4210-jpeg", "samsung,exynos4212-jpeg", > + "samsung,exynos5420-jpeg", "samsung,exynos5433-jpeg"; I am not convinced that this is needed because exynos4212-jpeg is equal to exynos4210-jpeg... It is a little bit weird because Jacek's commit 3246fdaa0ac2d9 ("[media] s5p-jpeg: Add support for Exynos3250 SoC") changed the driver data for Exynos4210 from S5P to Exynos4 without explaining it... However if these compatibles are exactly equal then only one should be preferred. It makes everything easier. Second can be still documented e.g. as deprecated. Best regards, Krzysztof