From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbcGOIOv (ORCPT ); Fri, 15 Jul 2016 04:14:51 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:11141 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbcGOIOr (ORCPT ); Fri, 15 Jul 2016 04:14:47 -0400 X-AuditID: cbfec7f5-f792a6d000001302-98-57889b740984 Message-id: <57889B73.4090607@samsung.com> Date: Fri, 15 Jul 2016 10:14:43 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Shuah Khan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com, hans.verkuil@cisco.com, javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg References: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> <578890BA.8040101@samsung.com> In-reply-to: <578890BA.8040101@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsVy+t/xK7olszvCDc78k7KY9bKdxWL+kXOs Fv1vFrJaLPm5i8ni3KuVjBZv3q5hsnj9wtCi//FrZotNj6+xWlzeNYfNYsb5fUwWS69fZLJY /azCYsL0tSwWrXuPsFtM/fKBxUHAY828NYweU35vZPW43NfL5LFy+Rc2j02rOtk8Ni+p99jS f5fdo2/LKkaPz5vkAjijuGxSUnMyy1KL9O0SuDIOHethL/jCX9Ew6QxbA+Mq3i5GTg4JAROJ tVseMkHYYhIX7q1n62Lk4hASWMoo8e38CSYI5xmjROf+7WwgVbwCWhLbzk9iAbFZBFQlNvxa xAxiswkYSvx88RpskqhAhMSf0/tYIeoFJX5MvgdWLwJUc3D3drChzAKzmCWOvtsLNlRYIFxi 4vnfYEVCAukS1450gzVzCmhL7Dh3nB3EZhawlVjwfh0LhC0vsXnNW+YJjAKzkOyYhaRsFpKy BYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCouzrDsalx6wOMQpwMCrx8O441B4uxJpY VlyZe4hRgoNZSYR359SOcCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9DwG6OrEkNTs1tSC1 CCbLxMEp1cB4WkXThH99M0vj2x/vDqWmW3Xp1+/MfeSQtt92Jcvpr9MV9vT0tnjL+4gzTk+8 uiA0STfQ8Xjhn/XCi/wjFu29cPXZjLPrdjrEcMjFf515KvSqGaOH46T4eKa8DTP53Bhidn7Z W+fr5uFyrtsuyfnjI81Op0knroRrFEonh//qO+Eyce2FX8pKLMUZiYZazEXFiQBlwvcErgIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 07/15/2016 09:28 AM, Krzysztof Kozlowski wrote: > On 07/14/2016 10:01 PM, Shuah Khan wrote: >> Add add missing documentation for samsung,exynos4212-jpeg codec, >> reorder entries to improve readability and make it easier to add >> new entries. >> >> Signed-off-by: Shuah Khan >> --- >> Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt >> index 38941db..093614c 100644 >> --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt >> +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt >> @@ -3,9 +3,9 @@ Samsung S5P/EXYNOS SoC series JPEG codec >> Required properties: >> >> - compatible : should be one of: >> - "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg", >> - "samsung,exynos3250-jpeg", "samsung,exynos5420-jpeg", >> - "samsung,exynos5433-jpeg"; >> + "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", >> + "samsung,exynos4210-jpeg", "samsung,exynos4212-jpeg", >> + "samsung,exynos5420-jpeg", "samsung,exynos5433-jpeg"; > > I am not convinced that this is needed because exynos4212-jpeg is equal > to exynos4210-jpeg... It is a little bit weird because Jacek's commit > 3246fdaa0ac2d9 ("[media] s5p-jpeg: Add support for Exynos3250 SoC") > changed the driver data for Exynos4210 from S5P to Exynos4 without > explaining it... It was probably a bug fix since 4210 and 4212 have the same JPEG IP. I agree that it isn't best practice to smuggle bug fixes like that. > However if these compatibles are exactly equal then > only one should be preferred. It makes everything easier. Second can be > still documented e.g. as deprecated. Still, both of them are present in the driver. Shouldn't it be reflected in the documentation? -- Best regards, Jacek Anaszewski