From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932342AbcGOJak (ORCPT ); Fri, 15 Jul 2016 05:30:40 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:39381 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbcGOJai (ORCPT ); Fri, 15 Jul 2016 05:30:38 -0400 X-AuditID: cbfec7f5-f792a6d000001302-36-5788ad3a82bd Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg To: Jacek Anaszewski References: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> <578890BA.8040101@samsung.com> <57889B73.4090607@samsung.com> <57889C23.3050106@samsung.com> <57889EAB.30502@samsung.com> <57889FD5.9070302@samsung.com> <5788AA5E.3070301@samsung.com> Cc: Shuah Khan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com, hans.verkuil@cisco.com, javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5788AD39.1010108@samsung.com> Date: Fri, 15 Jul 2016 11:30:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <5788AA5E.3070301@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t/xK7pWazvCDTbsVrWY9bKdxWL+kXOs Fv1vFrJaLPm5i8ni3KuVjBa9V58zWrx5u4bJ4vULQ4v+x6+ZLTY9vsZqcXnXHDaLGef3MVks vX6RyWL1swqLCdPXsli07j3CbjH1ywcWB0GPNfPWMHpM+b2R1eNyXy+Tx8rlX9g8Nq3qZPPY vKTeY0v/XXaPvi2rGD0+b5IL4IzisklJzcksSy3St0vgyjh/dTpTwS/+ij3PHrI2MF7i6WLk 5JAQMJE4fvcYE4QtJnHh3no2EFtIYCmjxKsd4l2MXED2M0aJa7NvgiWEBcIlJp7/zQJiiwjo SzQ09DFCFLUwSXx7P4sNxGEWmMUscfTdXrAONgFjic3Ll4DZvAJaEs29m9lBbBYBVYn+lV8Y QWxRgQiJWdt/MEHUCEr8mHwPbAOngLZEw+ftzF2MHEBD9STuX9QCCTMLyEtsXvOWeQKjwCwk HbMQqmYhqVrAyLyKUTS1NLmgOCk910ivODG3uDQvXS85P3cTIyTWvu5gXHrM6hCjAAejEg/v jkPt4UKsiWXFlbmHGCU4mJVEeCev6AgX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0 xJLU7NTUgtQimCwTB6dUA2OhN5Mpe1RelR7L+sb1YqU9QZWu8WU5GZM70zPi7b9VLgx/6TLp 8pd63ynq5i996mP7otMuM7OrqbyV2NK0XOi40OOihPhXGg3/un1PxdrNuuwlcr5vQ/e1GiWf XPWHCcsOpy1+5CvzZ7bP84VLzx2oYTDjFSlrs1dnVdthWfJHXi7PKttWiaU4I9FQi7moOBEA Na71XbECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 11:18 AM, Jacek Anaszewski wrote: > On 07/15/2016 10:33 AM, Krzysztof Kozlowski wrote: >> On 07/15/2016 10:28 AM, Jacek Anaszewski wrote: >>> On 07/15/2016 10:17 AM, Krzysztof Kozlowski wrote: >>>> On 07/15/2016 10:14 AM, Jacek Anaszewski wrote: >>>>>> However if these compatibles are exactly equal then >>>>>> only one should be preferred. It makes everything easier. Second >>>>>> can be >>>>>> still documented e.g. as deprecated. >>>>> >>>>> Still, both of them are present in the driver. Shouldn't it be >>>>> reflected >>>>> in the documentation? >>>> >>>> Right, it is a good practice, so how about: >>>> >>>> - compatible : should be one of: >>>> "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", >>>> "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg", >>>> "samsung,exynos5433-jpeg"; >>>> >>>> Deprecated: "samsung,exynos4212-jpeg" >>>> >>>> (or any other formatting) >>>> plus update to DTS changing it to 4210? >>> >>> Why newer 4212 version should be made deprecated? >> >> I don't mind the other way. However it seems logical to me that newer >> chip is compatible with existing one so the existing one (older) is >> used. When adding support for new devices, for most of re-usable drivers >> we use old compatibles. But as I said, it doesn't really matter to me. > > Frankly speaking marking a compatible deprecated looks weird to me. > It can be interpreted in the way that the device itself is deprecated > or it is not fully reliable. Marking a compatible or a property deprecated is commonly used, if needed of course. It has nothing to do with device being deprecated. This is documentation for bindings and deprecation affects only bindings. It is not weird or something strange. We already did this for some of Exynos compatibles (later removing them) and there are quite many examples in Documentation already. Best regards, Krzysztof > I'd just accept the patch in the original > form.