From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932930AbcGOMOT (ORCPT ); Fri, 15 Jul 2016 08:14:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43911 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932764AbcGOMOR (ORCPT ); Fri, 15 Jul 2016 08:14:17 -0400 Message-ID: <5788D397.9030904@redhat.com> Date: Fri, 15 Jul 2016 08:14:15 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stanislaw Gruszka , "Grumbach, Emmanuel" CC: "linux-kernel@vger.kernel.org" , linuxwifi , "Coelho, Luciano" , "Berg, Johannes" , "kvalo@codeaurora.org" , "Ivgi, Chaya Rachel" , "netdev@vger.kernel.org" , "Sharon, Sara" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded References: <1468250301-10357-1-git-send-email-prarit@redhat.com> <5783E33E.7090205@redhat.com> <1468261650.20877.14.camel@intel.com> <20160714092408.GA27271@redhat.com> <0BA3FCBA62E2DC44AF3030971E174FB3466901DA@hasmsx107.ger.corp.intel.com> <20160715112552.GB6939@redhat.com> In-Reply-To: <20160715112552.GB6939@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 15 Jul 2016 12:14:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote: > On Thu, Jul 14, 2016 at 09:44:22AM +0000, Grumbach, Emmanuel wrote: >>> If I understad correctly this error happen 100% of the time, not only during >>> init. Hence seems there is an issue here, i.e. cur_ucode is not marked >>> correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the >>> time (iwl_mvm_is_tt_in_fw() incorrecly return true on Prarit device ? ). >> >> Cur_ucode will not be IWL_UCODE_REGULAR until you load the firmware which >> will happen upon ifup. > > Then creating thermal_device on ifup looks more reasonable to me. > Otherwise we can create device that can be non-functional virtually > forever, i.e. when soft RFKILL is enabled. However I admit that > creating thermal_device when HW is detected has some advantages > too. That's my plan right now. Unfortunately something else in the kernel seems recently broken and is preventing me from testing. I will get back to this early next week. P. > > Stanislaw >