From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752949AbcGSG7s (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jul 2016 02:59:48 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:56903 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752861AbcGSG7o (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jul 2016 02:59:44 -0400
X-AuditID: cbfec7f5-f792a6d000001302-03-578dcfddde18
Message-id: <578DCFDC.5030200@samsung.com>
Date: Tue, 19 Jul 2016 08:59:40 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        David Rivshin <drivshin@allworx.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Richard Purdie <rpurdie@rpsys.net>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org, kernel@pyra-handheld.com,
        marek@goldelico.com, letux-kernel@openphoenux.org,
        Andrey Utkin <andrey_utkin@fastmail.com>
Subject: Re: [PATCH v3 1/2] drivers: led: is31fl319x: 1/3/6/9-channel light
 effect led driver
References: <cover.1468007377.git.hns@goldelico.com>
 <524f16ecba240bacf57924f43ec38404cfdcde8f.1468007377.git.hns@goldelico.com>
 <57854FB0.1080605@gmail.com>
 <71F3BE12-FFC9-4771-BF48-ABAC3ACEF4AD@goldelico.com>
In-reply-to: <71F3BE12-FFC9-4771-BF48-ABAC3ACEF4AD@goldelico.com>
Content-type: text/plain; charset=windows-1252; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsVy+t/xK7p3z/eGG7y7qGHx/9s1Fov5R86x
	Wix7eYrNov/NQlaLH9u+Mlmce7WS0eL21g0sFpe+1lhs/XOJzeLyrjlsFlvfrGO0+Ld0C5vF
	0usXmSwmTF/LYtG69wi7xe5dT1kdBDwaup+yeayZt4bR43JfL5PHopfz2T12zrrL7rHm/Slm
	j5XLv7B5bFrVyebRMmkXu8eXlmZmjz3zf7B6fN4kF8ATxWWTkpqTWZZapG+XwJVx9/1HloJt
	vBXrLx9jb2Ds5Opi5OSQEDCRePbhGBOELSZx4d56ti5GLg4hgaWMEsc/XWcESQgJPGOUOLrC
	D8TmFdCS+Hr8MzOIzSKgKvH41BMWEJtNwFDi54vXYINEBSIk/pzexwpRLyjxY/I9sBoRAT2J
	zu9/WEAWMAv0s0jcX/UOaBsHh7BAvMSBY3UQi28wSkzqeAe2gFPAUWL6iudgNrOArcSC9+tY
	IGx5ic1r3jJPYBSYhWTHLCRls5CULWBkXsUomlqaXFCclJ5rpFecmFtcmpeul5yfu4kREoVf
	dzAuPWZ1iFGAg1GJhzeBrTdciDWxrLgy9xCjBAezkgivwymgEG9KYmVValF+fFFpTmrxIUZp
	DhYlcd6Zu96HCAmkJ5akZqemFqQWwWSZODilGhjj1kqHK/7bYiPUtG7ySqtlN9My7zL/9riW
	d0P6fxWfTJC41/O1jz/yS5xzspaNWpvHJrXV4UsY33wrQ/8E5/rT1VN+anyue/DupXPJ6Qnl
	MwoF1a5unn6n8OzdhiNH36tNaF5hmtfyNWsOk8ECm3eCp7LeHqxjvCB1WW0C08mu/6K7V9/6
	ouGrxFKckWioxVxUnAgA0+MtSL4CAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Nikolaus,

On 07/15/2016 10:08 AM, H. Nikolaus Schaller wrote:
> Hi Jacek,
>
>> Am 12.07.2016 um 22:14 schrieb Jacek Anaszewski <jacek.anaszewski@gmail.com>:
>>
>>>
>>> +
>>> +/*
>>> + * regmap is used as a cache of chip's register space,
>>> + * to avoid reading back brightness values from chip,
>>> + * which is known to hang.
>>> + */
>>> +struct is31fl319x_chip {
>>> +	struct i2c_client       *client;
>>> +	struct regmap           *regmap;
>>> +	struct mutex            lock;
>>> +	u32                     audio_gain_db;
>>> +
>>> +	struct is31fl319x_led {
>>> +		struct is31fl319x_chip  *chip;
>>> +		struct led_classdev     cdev;
>>> +		u32                     max_microamp;
>>> +		bool                    configured;
>>> +	} leds[NUM_LEDS];
>>> +};
>>> +
>>> +static const struct i2c_device_id is31fl319x_id[] = {
>>> +	{ "is31fl3190", 1 },
>>> +	{ "is31fl3191", 1 },
>>> +	{ "is31fl3193", 3 },
>>> +	{ "is31fl3196", 6 },
>>> +	{ "is31fl3199", 9 },
>>> +	{ "sn3199", 9 },
>>> +	{ }
>>> +};
>>> +MODULE_DEVICE_TABLE(i2c, is31fl319x_id);
>>
>> This is redundant - you have this info in of_is31fl319x_leds_match,
>> and you can obtain it with of_match_device().
>> Please compare drivers/leds/leds-is31fl32xx.c.
>
> we have tried like is31fl32xx.c but it does not automatically load the driver
> if compiled as module (like all other I2C clients do). Reason seems to
> be that there is no i2c information in modalias database any more.
>
> So perhaps the i31fl32 approach is also incomplete. Has it been tested
> with loadable modules?

Having the issue clarified, please proceed accordingly in case of
your driver.

-- 
Best regards,
Jacek Anaszewski