From: Yang Shi <yang.shi@linux.alibaba.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: mhocko@kernel.org, ldufour@linux.vnet.ibm.com, vbabka@suse.cz,
kirill@shutemov.name, akpm@linux-foundation.org,
dave.hansen@intel.com, oleg@redhat.com,
srikar@linux.vnet.ibm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v10 PATCH 1/3] mm: mmap: zap pages with read mmap_sem in munmap
Date: Mon, 17 Sep 2018 12:49:49 -0700 [thread overview]
Message-ID: <578efe1c-0de0-d71d-ac14-cf5b74e2a713@linux.alibaba.com> (raw)
In-Reply-To: <20180915092101.GA31572@bombadil.infradead.org>
On 9/15/18 2:21 AM, Matthew Wilcox wrote:
> On Sat, Sep 15, 2018 at 04:34:57AM +0800, Yang Shi wrote:
>> Suggested-by: Michal Hocko <mhocko@kernel.org>
>> Suggested-by: Kirill A. Shutemov <kirill@shutemov.name>
>> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Reviewed-by: Matthew Wilcox <willy@infradead.org>
>
> Looks good! Thanks for sticking with this patch series.
Thanks for reviewing this patch series. I'm going to wait for one or two
days to see whether anyone else has more comments before I have the
spelling error fixed.
Yang
>
> Minor spelling fixes:
>
>> - /*
>> - * Remove the vma's, and unmap the actual pages
>> - */
>> + /* Detatch vmas from rbtree */
> "Detach"
>
>> + /*
>> + * mpx unmap need to be handled with write mmap_sem. It is safe to
>> + * deal with it before unmap_region().
>> + */
> * mpx unmap needs to be called with mmap_sem held for write.
> * It is safe to call it before unmap_region()
>
>> + ret = __do_munmap(mm, start, len, &uf, downgrade);
>> + /*
>> + * Returning 1 indicates mmap_sem is down graded.
>> + * But 1 is not legal return value of vm_munmap() and munmap(), reset
>> + * it to 0 before return.
>> + */
> "downgraded" is one word.
next prev parent reply other threads:[~2018-09-17 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 20:34 [RFC v10 PATCH 0/3] mm: zap pages with read mmap_sem in munmap for large mapping Yang Shi
2018-09-14 20:34 ` [RFC v10 PATCH 1/3] mm: mmap: zap pages with read mmap_sem in munmap Yang Shi
2018-09-15 9:21 ` Matthew Wilcox
2018-09-17 19:49 ` Yang Shi [this message]
2018-09-14 20:34 ` [RFC v10 PATCH 2/3] mm: unmap VM_HUGETLB mappings with optimized path Yang Shi
2018-09-15 9:44 ` Matthew Wilcox
2018-09-14 20:34 ` [RFC v10 PATCH 3/3] mm: unmap VM_PFNMAP " Yang Shi
2018-09-15 9:45 ` Matthew Wilcox
2018-09-15 10:10 ` [RFC v10 PATCH 0/3] mm: zap pages with read mmap_sem in munmap for large mapping Matthew Wilcox
2018-09-17 20:00 ` Yang Shi
2018-09-18 10:37 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578efe1c-0de0-d71d-ac14-cf5b74e2a713@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=kirill@shutemov.name \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).